Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#8321 closed defect (fixed)

Notifications are being sent with charset="ascii" instead of "us-ascii"

Reported by: sponge_bob_128@… Owned by: Remy Blank
Priority: normal Milestone: 0.11.5
Component: notification Version: 0.11.4
Severity: normal Keywords: ascii us-ascii needinfo
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Trac is sending notifications as charset="ascii" instead of charset="us-ascii" when [notification]mime_encoding = none. "ascii" is not recognized by the latest Thunderbird "out of the box" I assume because "ascii" is a nonstandard charset ID. Thunderbird then ignores all Trac notification email bodies with respect to searching and email filters.

Attachments (0)

Change History (7)

comment:1 by Christian Boos, 15 years ago

Which version are you using?

Since r8218, there's only one place left where 'ascii' is explicitly set as an encoding, and that seems to be for the header only (see branches/0.11-stable/trac/notification.py@8218#L251).

Can you try with that (or a more recent) version and see if the problem with Thunderbird persists?

comment:2 by Christian Boos, 15 years ago

Keywords: needinfo added

comment:3 by sponge_bob_128@…, 15 years ago

If I change all 'ascii' strings to 'us-ascii' in notification.py, it stops sending messages with charset='ascii' (fixes the bug).

comment:4 by Christian Boos, 15 years ago

As you say "all 'ascii'" strings, it looks like you haven't tried with branches/0.11-stable/trac/notification.py@8218 unmodified. By doing that check, this will enable us to see if the only remaining occurrence of 'ascii' on line 251 really needs to be fixed or not.

comment:5 by anonymous, 15 years ago

Resolution: fixed
Status: newclosed
Version: 0.11-stable0.11.4

Looks like this has been fixed between 0.11-4 and 0.11-stable. The one 'ascii' in 0.11-stable does not effect the output.

comment:6 by Christian Boos, 15 years ago

Owner: changed from Emmanuel Blot to Remy Blank

So that was r8218, thanks for the feedback!

comment:7 by Christian Boos, 15 years ago

Milestone: 0.11.5

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.