[PATCH] Forward additional parameters from /report to /query

[thomas.moschny@…]

Calling an URL like this

http://myserver.example/trac/report/10

redirects to

http://myserver.example/trac/query?col=x&status=new&...&report=10

Now, it would be nice, if additional parameters could be passed to the (short) report URL and not be forgotten while redirecting to the query, e.g.

http://myserver.example/trac/report/10?format=csv&col=description

would redirect to

http://myserver.example/trac/query?col=x&status=new&...&col=description&report=10&format=csv

Ideally, these parameters would be given precedence over those from the report definition (where applicable - i.e. col parameters would simply be added, like in the example).

[Christian Boos]

Good idea (and a patch do wonders to get a closer milestone…)

[Jaya Kirtani <jaya.kirtani@…>]

Above attached patch updates the code to forward the additional parameters from /report to /query. The patch adds unit test case to test the same. Also verified that the change passes the existing unit and functional test cases.

[Christian Boos]

Thanks for the patch! But a rapid look shows you didn't read the patch guidelines (e.g. PatchWelcome and the links there)…

[Jaya Kirtani <jaya.kirtani@…>]

I did look at the patch guidelines. After again looking at the patch I could find a couple of places where spaces are missing.Can you please mention if there is anything specific?

[Jaya Kirtani <jaya.kirtani@…>]

Updated patch to fix coding style issues

[Jaya Kirtani <jaya.kirtani@…>]

Made following changes :

1. Added missing spaces (for assignment operator etc)
2. Replaced "" with for string constants.

Please let me know if I missed anything else.

[Ryan J Ollos]

This could help with the request in ​th:#8030 as well. Rather than allowing batch modify on the report page, the user could easily navigate to the query page to batch modify the tickets.