ValueError: need more than 1 value to unpack

[ejima]

How to Reproduce

While doing a GET operation on /ticket/391, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{'id': u'391'}

User Agent was: Mozilla/5.0 (Windows; U; Windows NT 5.0; ja; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8

System Information

Trac	0.11.1.ja1
Python	2.5.2 (r252:60911, Feb 21 2008, 13:11:45) [MSC v.1310 32 bit (Intel)]
setuptools	0.7a1
SQLite	3.3.4
pysqlite	2.3.2
Genshi	0.5
mod_python	3.3.1
Subversion	1.5.2 (r32768)
jQuery:	1.2.6

Python Traceback

Traceback (most recent call last):
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\web\main.py", line 424, in _dispatch_request
    dispatcher.dispatch(req)
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\web\main.py", line 220, in dispatch
    data, content_type)
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\web\chrome.py", line 715, in render_template
    return stream.render(method, doctype=doctype)
  File "build\bdist.win32\egg\genshi\core.py", line 179, in render
    return encode(generator, method=method, encoding=encoding, out=out)
  File "build\bdist.win32\egg\genshi\output.py", line 60, in encode
    return _encode(u''.join(list(iterator)))
  File "build\bdist.win32\egg\genshi\output.py", line 311, in __call__
    for kind, data, pos in stream:
  File "build\bdist.win32\egg\genshi\output.py", line 753, in __call__
    for kind, data, pos in stream:
  File "build\bdist.win32\egg\genshi\output.py", line 592, in __call__
    for kind, data, pos in stream:
  File "build\bdist.win32\egg\genshi\output.py", line 698, in __call__
    for kind, data, pos in chain(stream, [(None, None, None)]):
  File "build\bdist.win32\egg\genshi\output.py", line 532, in __call__
    for ev in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\web\chrome.py", line 767, in _strip_accesskeys
    for kind, data, pos in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\web\chrome.py", line 756, in _generate
    for kind, data, pos in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 686, in _unmark
    for mark, event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 1080, in __call__
    for mark, event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 117, in __iter__
    event = self.stream.next()
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 713, in __call__
    for mark, event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 682, in _mark
    for event in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 686, in _unmark
    for mark, event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 1080, in __call__
    for mark, event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 117, in __iter__
    event = self.stream.next()
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 713, in __call__
    for mark, event in stream:
  File "build\bdist.win32\egg\genshi\filters\transform.py", line 682, in _mark
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 569, in _include
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\markup.py", line 299, in _match
    ctxt, match_templates[idx + 1:], **vars):
  File "build\bdist.win32\egg\genshi\template\markup.py", line 299, in _match
    ctxt, match_templates[idx + 1:], **vars):
  File "build\bdist.win32\egg\genshi\template\markup.py", line 246, in _match
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 543, in _exec
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 533, in _eval
    for event in substream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 496, in _eval
    for kind, data, pos in stream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 551, in _flatten
    for event in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "build\bdist.win32\egg\genshi\path.py", line 141, in _generate
    subevent = stream.next()
  File "build\bdist.win32\egg\genshi\template\base.py", line 569, in _include
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\markup.py", line 235, in _strip
    event = stream.next()
  File "build\bdist.win32\egg\genshi\template\base.py", line 543, in _exec
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 533, in _eval
    for event in substream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 496, in _eval
    for kind, data, pos in stream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 551, in _flatten
    for event in stream:
  File "build\bdist.win32\egg\genshi\core.py", line 283, in _ensure
    for event in stream:
  File "build\bdist.win32\egg\genshi\path.py", line 141, in _generate
    subevent = stream.next()
  File "build\bdist.win32\egg\genshi\template\base.py", line 569, in _include
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\markup.py", line 235, in _strip
    event = stream.next()
  File "build\bdist.win32\egg\genshi\template\base.py", line 543, in _exec
    for event in stream:
  File "build\bdist.win32\egg\genshi\template\base.py", line 520, in _eval
    result = _eval_expr(data, ctxt, **vars)
  File "build\bdist.win32\egg\genshi\template\base.py", line 286, in _eval_expr
    retval = expr.evaluate(ctxt)
  File "build\bdist.win32\egg\genshi\template\eval.py", line 180, in evaluate
    return eval(self.code, _globals, {'__data__': data})
  File "T:\TracLightning\python\lib\site-packages\trac-0.11.1.ja1-py2.5.egg\trac\ticket\templates\ticket.html", line 199, in <Expression u'wiki_to_html(context, ticket.description, escape_newlines=preserve_newlines)'>
    ${wiki_to_html(context, ticket.description, escape_newlines=preserve_newlines)}
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\wiki\formatter.py", line 1096, in format_to_html
    return HtmlFormatter(env, context, wikidom).generate(escape_newlines)
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\wiki\formatter.py", line 1055, in generate
    escape_newlines)
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\wiki\formatter.py", line 860, in format
    result = re.sub(self.wikiparser.rules, self.replace, line)
  File "T:\TracLightning\python\lib\re.py", line 150, in sub
    return _compile(pattern, 0).sub(repl, string, count)
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\wiki\formatter.py", line 807, in replace
    replacement = self.handle_match(fullmatch)
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\wiki\formatter.py", line 800, in handle_match
    return external_handler(self, match, fullmatch)
  File "t:\traclightning\python\lib\site-packages\Trac-0.11.1.ja1-py2.5.egg\trac\wiki\api.py", line 284, in wikipagename_with_label_link
    page, label = match[1:-1].split(' ', 1)
ValueError: need more than 1 value to unpack

[Tim Hatch]

Can you get the original text with appending ?format=txt to the url and attach that to the ticket, so we can see if it affects core Trac or only trac-ja?

[Christian Boos]

The corresponding regexp for this match is normally:

    r"!?\[%s\s+(?:%s|[^\]]+)\]" % (wiki_page_name,
                                   WikiParser.QUOTED_STRING)

The split on ' ' can fail if \s+ matches something which doesn't contain a space character. In theory this could already happen for a tab character ('\t'), but maybe there are also some Japanese characters also matched by \s+?

So maybe we should use capture groups here.

[Christian Boos]

Duplicate of #8757.