a SMTPAuthenticationError shouldn't be presented as an internal error

[huayna@…]

How to Reproduce

While doing a GET operation on /wiki, Trac issued an internal error.

(please provide additional details here)

User Agent was: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6

System Information

Trac	0.11.2.1
Python	2.5.2 (r252:60911, Jul 31 2008, 17:28:52) [GCC 4.2.3 (Ubuntu 4.2.3-2ubuntu7)]
setuptools	0.6c9
psycopg2	2.0.8
Genshi	0.5.1
Subversion	1.4.6 (r28521)
jQuery:	1.2.6

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/Trac-0.11.2.1-py2.5.egg/trac/web/main.py", line 432, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.5/site-packages/Trac-0.11.2.1-py2.5.egg/trac/web/main.py", line 216, in dispatch
    self._post_process_request(req, *resp)
  File "/usr/lib/python2.5/site-packages/Trac-0.11.2.1-py2.5.egg/trac/web/main.py", line 308, in _post_process_request
    resp = f.post_process_request(req, *resp)
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 560, in post_process_request
    self._send_email(req)
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 599, in _send_email
    notifier.notify(req.authname, req.session['email_verification_token'])
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 529, in notify
    SingleUserNofification.notify(self, username, subject)
  File "build/bdist.linux-i686/egg/acct_mgr/web_ui.py", line 123, in notify
    NotifyEmail.notify(self, username, subject)
  File "/usr/lib/python2.5/site-packages/Trac-0.11.2.1-py2.5.egg/trac/notification.py", line 246, in notify
    Notify.notify(self, resid)
  File "/usr/lib/python2.5/site-packages/Trac-0.11.2.1-py2.5.egg/trac/notification.py", line 134, in notify
    self.begin_send()
  File "/usr/lib/python2.5/site-packages/Trac-0.11.2.1-py2.5.egg/trac/notification.py", line 328, in begin_send
    self.server.login(self.user_name, self.password)
  File "/usr/lib/python2.5/smtplib.py", line 591, in login
    raise SMTPAuthenticationError(code, resp)
SMTPAuthenticationError: (535, '5.7.1 Username and Password not accepted. Learn more at\n5.7.1 http://mail.google.com/support/bin/answer.py?answer=14257 z20sm4589536pod.12')

[Gregor Wegberg]

Did you tried what is written at the given link? ​http://mail.google.com/support/bin/answer.py?answer=14257

I did it and it worked so far on my testsystem. I only had to do the captcha test and rerun the whole thing.

cheers, gregor

[Christian Boos]

Still, we shouldn't end up with a backtrace in this case, I think.

Catching SMTPAuthenticationError and throwing a nicer Trac error would be better in this case.

[Remy Blank]

I'll add a nicer message, but maybe as a warning message rather than a TracError.

[Remy Blank]

With [8739], a warning is displayed if an error occurs while sending notifications.