Sort browser entries by author

[Emmanuel Blot]

It is sometimes quite useful to sort the browser entries by author.

Typical usage is to find who keeps obsoleted branches, or quick-find user's own development branches.

Attaching a patch to allow sort by author of the browser view

[Emmanuel Blot]

Patch to enable by-author sorting

[Christian Boos]

Good idea, but the patch doesn't seem to be complete, as if we add an Author column, we should also remove the author name from the Last Change column.

I'd rather have that for 0.12 though.

[Emmanuel Blot]

Replying to cboos:

Good idea, but the patch doesn't seem to be complete, as if we add an Author column, we should also remove the author name from the Last Change column.

I may have missed something, but the author is removed from the Last Change column - or are you referring to another page but the "browser" view?

[Emmanuel Blot]

New browser view

[Christian Boos]

Sorry, yest I missed something ;-) The former <author>: part was done in the template and for some reason I assumed that this was done in the controller…

So it's good to go as far I'm concerned.

[Christian Boos]

(perhaps post-pone to after MultiRepos integration, as to minimize merge hassle)

[Emmanuel Blot]

Ok, no problem.

[Remy Blank]

I took the liberty to refresh the patch and apply it in [9159]. Manu, I hope you don't mind.

It's funny in this case how adding functionality actually made the template code simpler. And I like the following syntax for including templates with arguments:

<xi:include href="sortable_th.html" py:with="class_ = 'name'; title = _('Name')"/>

It's quite close to a function call :-)

[Christian Boos]

The Author column is really too wide for backends that usually have the author name in full with an e-mail address (like Mercurial, git). We should shorten the names, doing something better that what we already do in annotate, which could be fixed at this occasion as well (short_author = chgset.author.split(' ', 1)[0]).

[Remy Blank]

Yes, I noticed that when I set up my own multirepos instance, too. The issue was already present before, though, when the author was part of the message column.

Splitting at the first space is far from ideal, indeed. The clean solution probably depends on #2456 and the possibility to define aliases for users (I use my normal username for Subversion, but "First Last <address@…>" for Mercurial).

Any ideas simple enough that we could fix this for 0.12? Otherwise, as the issue is no worse than before, we could keep this ticket closed and target a new one to a later milestone.

[Christian Boos]

I think the issue is worse than before, as the width of the column is now the width of the longest name…

We could try to fetch the shortname out of "… <shortname@…>", for example.

[Remy Blank]

You're right. I hadn't thought of that, because the author for all the changesets in my repositories is always the same :)

Good idea with the shortname, I'll try that, and use the same for the annotated view.

[Remy Blank]

Fixed in [9240]. The next question is, should we do the same in the log view?

[Christian Boos]

Replying to rblank:

… should we do the same in the log view?

Yes, it looks nicer as well (and we should be consistent in the styling as well).

Done with some other tweaks in r9245.