Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#8028 closed defect (fixed)

Definition lists don't get "wiki" class

Reported by: sdrongel@… Owned by: Christian Boos
Priority: low Milestone: 0.12
Component: wiki system Version: 0.11
Severity: minor Keywords: patch
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Definition lists made in Wiki formatting don't get the "wiki" class. As a consequence, the rule in css/trac.css to show all definition terms as bold has no effect.

A trivial fix is included.

Attachments (1)

trac_01-deflists_class.patch (515 bytes ) - added by sdrongel@… 15 years ago.
A patch to ensure <dl> gets class "wiki"

Download all attachments as: .zip

Change History (5)

by sdrongel@…, 15 years ago

A patch to ensure <dl> gets class "wiki"

comment:1 by Christian Boos, 15 years ago

Component: generalwiki system
Milestone: 0.11.4
Owner: set to Christian Boos

comment:2 by Christian Boos, 15 years ago

Milestone: 0.11.40.12
Priority: normallow
Severity: normalminor

Though the fix is trivial, I think we'd rather make that change on trunk only, as the lack of automatic "bold" certainly encouraged people to use their own bold markup for terms ''' ... ''' :: definition. So it might be surprising for them to suddenly see bold terms when they explicitly added markup for it and when they didn't.

comment:3 by Christian Boos, 15 years ago

Patch applied on trunk in r8046 + updated wiki tests.

Also, I think I changed my mind regarding 0.11-stable and I think it's not that a big deal to backport it, as I thought. So if someone else is in favor of a backport, I'll do it.

comment:4 by Christian Boos, 15 years ago

Resolution: fixed
Status: newclosed

Let's leave that for 0.12 only.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.