Modify ↓
#800 closed defect (fixed)
'Add New Milestone' not working
| Reported by: | Owned by: | Christopher Lenz | |
|---|---|---|---|
| Priority: | high | Milestone: | 0.8 |
| Component: | roadmap | Version: | devel |
| Severity: | critical | Keywords: | |
| Cc: | brad@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
I pulled Revision 940 to my local and was unable to create a new milestone. The problem was that the 'id' variable in Milestone.py was not being set to a default of -1 by the dictionary's get() method.
I'm a total Python newbie, so someone needs to check if the patch is a) in the right place, and b) the proper Python way. I don't think removing the hidden field name="id" on the html form is the way, because at times, it's filled with the milestone name for other modes.
Attachments (2)
Change History (8)
by , 21 years ago
| Attachment: | add_milestone.diff added |
|---|
comment:1 by , 21 years ago
Oops, forgot some particulars:
Gentoo Linux (2.6.6 kernel) Python 2.3.3 mod_python
anything else?
comment:2 by , 21 years ago
| Milestone: | → 0.8 |
|---|---|
| Priority: | normal → high |
| Severity: | normal → critical |
| Status: | new → assigned |
comment:3 by , 21 years ago
I was getting an error with the patch, something like
TypeError: len() of unsized object
So I changed the check to:
if id == "": id = -1;
Note:
See TracTickets
for help on using tickets.
patch file