Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#800 closed defect (fixed)

'Add New Milestone' not working

Reported by: Brad Anderson <brad@…> Owned by: Christopher Lenz
Priority: high Milestone: 0.8
Component: roadmap Version: devel
Severity: critical Keywords:
Cc: brad@… Branch:
Release Notes:
API Changes:

Description

I pulled Revision 940 to my local and was unable to create a new milestone. The problem was that the 'id' variable in Milestone.py was not being set to a default of -1 by the dictionary's get() method.

I'm a total Python newbie, so someone needs to check if the patch is a) in the right place, and b) the proper Python way. I don't think removing the hidden field name="id" on the html form is the way, because at times, it's filled with the milestone name for other modes.

Attachments (2)

add_milestone.diff (547 bytes ) - added by brad@… 15 years ago.
patch file
add_milestone.2.diff (542 bytes ) - added by brad@… 15 years ago.
patch file (Try #2)

Download all attachments as: .zip

Change History (8)

by brad@…, 15 years ago

Attachment: add_milestone.diff added

patch file

comment:1 by Brad Anderson <brad@…>, 15 years ago

Oops, forgot some particulars:

Gentoo Linux (2.6.6 kernel) Python 2.3.3 mod_python

anything else?

comment:2 by Christopher Lenz, 15 years ago

Milestone: 0.8
Priority: normalhigh
Severity: normalcritical
Status: newassigned

comment:3 by Brad Anderson <brad@…>, 15 years ago

I was getting an error with the patch, something like

TypeError: len() of unsized object

So I changed the check to:

if id == "":
   id = -1;

by brad@…, 15 years ago

Attachment: add_milestone.2.diff added

patch file (Try #2)

comment:4 by Jonas Borgström, 15 years ago

test

comment:5 by Jonas Borgström, 15 years ago

test2

comment:6 by Christopher Lenz, 15 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [941].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.