Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#7987 closed defect (fixed)

Backport of r7353 into mercurial plugin for trac 0.10.x

Reported by: Shun-ichi Goto <shunichi.goto@…> Owned by: shunichi.goto
Priority: normal Milestone: not applicable
Component: plugin/mercurial Version: 0.10-stable
Severity: normal Keywords: helpwanted
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

There is a same problem resolved by r7353 in mercurial plugin for trac 0.10.x (sandbox/mercurial-plugin). I'm grad to fix it:

  • tracvc/hg/backend.py

    diff -r b17fc805e7d7 tracvc/hg/backend.py
    a b  
    529529            if self.mflags: # Mercurial upto 9.1
    530530                exe = self.mflags[self.path]
    531531            else: # assume Mercurial version >= [abd9a05fca0b]
    532                 exe = self.manifest.execf(self.path)
     532                exe = 'x' in self.manifest.flags(self.path)
    533533            return exe and {'exe': '*'} or {}
    534534        return {}
    535535    # FIXME++: implement pset/pget/plist etc. in hg

Attachments (1)

issue7987-support_recent_hg.patch (4.3 KB ) - added by Shun-ichi Goto <shunichi.goto@…> 16 years ago.
patch for trac 0.10.5 with recent and old mercurials.

Download all attachments as: .zip

Change History (5)

comment:1 by Christian Boos, 16 years ago

Keywords: helpwanted added
Milestone: not applicable

Can you do the fix in the hasattr() style of r7353? I'm afraid to lose compatibility with older versions (people still using TracMercurial for Trac 0.10 are more likely to old mercurial versions as well).

comment:2 by Shun-ichi Goto <shunichi.goto@…>, 16 years ago

Sure. Ok, I've made the new patch, attached. And it also include another fix for API change revlog.linkrev() (#7981). I've played with mercurial 1.0, 1.0.1, 1.1 and tip on main, and tip on crew.

by Shun-ichi Goto <shunichi.goto@…>, 16 years ago

patch for trac 0.10.5 with recent and old mercurials.

comment:3 by Christian Boos, 16 years ago

Resolution: fixed
Status: newclosed

Patch applied in r7950, thanks!

comment:4 by Christian Boos, 16 years ago

Owner: changed from Christian Boos to shunichi.goto

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain shunichi.goto.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from shunichi.goto to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.