Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#7978 closed defect (fixed)

[patch] attachment stream is not closed when listeners are notified

Reported by: anatoly techtonik <techtonik@…> Owned by: techtonik@…
Priority: normal Milestone: 0.11.3
Component: attachment Version: 0.11-stable
Severity: major Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

IAttachmentChangeListener notifies plugins about added file with opened file description. It would not be a problem for a plugin to reopen closed file when it needs to analyze file contents (index or make virus checks), but it is a problem to close existing file.

Fix attached.

References:
http://trac-hacks.org/wiki/SearchAttachmentsPlugin
http://groups.google.com/group/trac-dev/browse_thread/thread/bf5b64a37f7ddffd/1963e1b3232cfe64

Attachments (2)

attachment.py-trunk-fix.diff (606 bytes ) - added by anatoly techtonik <techtonik@…> 16 years ago.
fix for trunk
attachment.py-0.11-fix.diff (608 bytes ) - added by anatoly techtonik <techtonik@…> 16 years ago.
fix for 0.11-stable

Download all attachments as: .zip

Change History (6)

by anatoly techtonik <techtonik@…>, 16 years ago

fix for trunk

by anatoly techtonik <techtonik@…>, 16 years ago

Attachment: attachment.py-0.11-fix.diff added

fix for 0.11-stable

comment:1 by Christian Boos, 16 years ago

Milestone: 0.11.3
Owner: set to Christian Boos
Status: newassigned

Ok, this seems to be a harmless change.

comment:2 by Christian Boos, 16 years ago

Milestone: 0.11.40.11.3

comment:3 by Christian Boos, 16 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in r7821, thanks!

comment:4 by Christian Boos, 16 years ago

Owner: changed from Christian Boos to techtonik@…

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain techtonik@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from techtonik@… to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.