Edgewall Software
Modify ↓

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#7974 closed defect (duplicate)

UnicodeDecodeError showing transplanted revision

Reported by: wbruna@… Owned by: Christian Boos
Priority: normal Milestone:
Component: plugin/mercurial Version: 0.11
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

​Transplanted changesets include an extra field 'transplanted_source', containing the original changeset hash (as a 20-byte buffer). The content is returned as-is by the plugin, so it triggers an UnicodeDecodeError when rendering.

I'd suggest simply discarding unknown extra fields. IMHO, there isn't a good way to display these fields generically, since they don't carry type information. And they're usually interesting only to extensions, since they can't be created with a regular commit.

For transplant_source in particular, it would be nice showing a link to the transplanted revision - or simply its ID, if the original revision isn't available (could happen on transplants across branches).

Attachments (0)

Change History (4)

in reply to:  description ; comment:1 by Christian Boos, 15 years ago

Resolution: → duplicate
Status: new → closed

Replying to wbruna@…:

… For transplant_source in particular, it would be nice showing a link to the transplanted revision - or simply its ID, if the original revision isn't available (could happen on transplants across branches).

It already should do so, please upgrade :-) - see #7471.

in reply to:  1 ; comment:2 by wbruna@…, 15 years ago

Replying to cboos:

It already should do so, please upgrade :-) - see #7471.

Hum, somehow I missed it… probably searched only for the error message. Anyway, it's good to keep this ticket around, since Debian Lenny will ship version 0.11.

Thanks, and sorry for the noise!
Wagner

in reply to:  2 comment:3 by wbruna@…, 15 years ago

Replying to wbruna@…:

since Debian Lenny will ship version 0.11.

r7354, actually.

in reply to:  2 comment:4 by Christian Boos, 15 years ago

Replying to wbruna@…:

… it's good to keep this ticket around, since Debian Lenny will ship version 0.11.

Thanks, this prompted me to update the TracMercurial page with a reference to the recent stable revisions (r7744 / r7757).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.