Default language wrongly displayed as english

[jouvin@…]

In trunk r7788, when opening the language panel in preferences in a browser where the preferred language is defined to french, the popup list wrongly displays "langage par défaut (anglais)" ("default language (english)"), even though french is actually the selected language/locale used by Trac.

Michel

[Christian Boos]

You're right - verifying this one actually made me try the default language negotiation code and I found a nice bug: req.languages shouldn't be sorted but should rather keep the ordering given in the Accept-Language header.

trac/web/api.py

@@ -536 +536 @@
                 except ValueError:
                     q = 0
             langs.append((-q, code))
-        langs.sort()
         return [code for q, code in langs]
 
     def _reconstruct_url(self):

Back to the point: I think there should be a note on the Language preference tab specifying that the "default language" corresponds to the language which was set in the browser preferences, and not to a server setting or (as I thought) to the English language.

[Christian Boos]

Replying to cboos:

… req.languages shouldn't be sorted but should rather keep the ordering given in the Accept-Language header

The problem was actually that sort didn't keep the original order in case of a tie on the quality coefficient. See attachment:t7973-Locale-negotiation-r7795.diff:ticket:7973​.

[jouvin@…]

With the patch the problem remains the same for me. Tested with 2 different browsers:

• IE : FR is the only language. From the project log:

  2009-01-15 13:58:41,113 Trac[main] DEBUG: Negociated locale: ['fr'] -> fr_FR
  

• Opera : several languages. From the project log:

  2009-01-15 14:02:12,782 Trac[main] DEBUG: Negociated locale: ['fr-fr', 'fr', 'en'] -> fr_FR
  

Michel

[Christian Boos]

Well yes, that patch doesn't fix the ("default language (english)") issue, only the other locale negotiation problem I discovered while checking this issue… (hope this clarifies).

[Christian Boos]

Also fixed in r8716, by Stéphane Raimbault.