Opened 16 years ago
Closed 16 years ago
#7949 closed enhancement (fixed)
Link milestone column in query results to milestone page
| Reported by: | Owned by: | Remy Blank | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.3 |
| Component: | report system | Version: | 0.11.1 |
| Severity: | normal | Keywords: | review |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
It would be nice if the milestone column on a query page linked to the appropriate milestone page. Patch against 0.11.1 attached.
Attachments (2)
Change History (6)
by , 16 years ago
| Attachment: | milestone-link.diff added |
|---|
comment:1 by , 16 years ago
| Milestone: | → 0.11.3 |
|---|---|
| Owner: | set to |
Sounds like a good idea. I'll put it on my to-do list.
by , 16 years ago
| Attachment: | 7949-milestone-link-r7782.patch added |
|---|
Patch against 0.11-stable adding links to milestones in ticket report and query
follow-up: 3 comment:2 by , 16 years ago
| Keywords: | review added |
|---|
The patch above adds links to milestones in ticket reports and queries, using a slightly simpler approach for getting the links (using href.milestone instead of a Resource object; in the original patch that resource was constructed with resource.child(), which is incorrect, as milestones are not children of tickets).
This works well, but has the disadvantage that the link rendering for milestones is hardcoded, instead of going through the milestone IResourceManager. So for example, closed milestones are not displayed with a strikeout style. IMO, this looks nicer anyway.
The major advantage is speed: going through the IResourceManager would require a DB query per ticket in the result set. Not acceptable IMO.
Opinions?
comment:3 by , 16 years ago
Replying to rblank:
Opinions?
Your patch works fine for me. As far as correctness goes, I was just trying to find a way to accomplish the task; documentation about what the various macros available to templates actually mean seems to be scarce in the version of Trac I have. Perhaps it's improved since then (or is available on the website, I didn't look in depth).
Suggested patch against 0.11.1