enhanced error during upgrade

[shanec@…]

I wanted to know what plugin is failing during an upgrade, so I modified Environment.upgrade to give me that information via an exception. patch to follow.

[Christian Boos]

Well, doing a commit after each partial upgrade seems wrong.

You should rather take note of the currently executing upgrade, then show the culprit when catching the exception, i.e. something like:

  module = None
  try:
      for participant in upgraders:
          module = participant.__module__.split('.')[0] 
          participant.upgrade_environment(db) 
      db.commit()
  except Exception, e:
      raise TracError("Unable to upgrade \"%s\": %s" % (module, e)) 

(untested)

[Remy Blank]

I'll implement comment:1, but probably not for 0.12.

[Remy Blank]

Trunk now logs the current upgrade participant, and performs each upgrade in a separate transaction, so this is no longer an issue.