trac-post-commit-hook/TracLink policy mismatch

[julien@…]

I just set up Trac 0.11.2.1 on my project and install the post commit hook for SVN.

Everything is working well. Thanks for all.

Client side, I use TortoiseSVN and I have defined the following properties on my trunk folder:

bugtraq:logregex
([cC]lose|[cC]losed|[cC]loses|[fF]ix|[fF]ixes|[fF]ixed|[rR]eferences|[rR]efs|[aA]ddresses|[rR]e|[sS]ee)\s+((\s*(,|and|&)?\s*)?(#|([tT]icket|[iI]ssue|[bB]ug)(\s|:)?)\d+)+
(\d+)

to suit the hook parsing convention. (Tortoise does a color highlighting in the commit log message when the regexpr match, add hyperlink and a column with ticket numbers in the show log dialog, so user-friendly.)

The fact is that TracLinks only match #<number> or ticket:<number> and not all the (#|([tT]icket|[iI]ssue|[bB]ug)(\s|:)?) possibilities so my comments have some link and other not…

Such a shame: the hook parsing and TracLinks naming convention are not the same.

Do you plan to update TracLinks ? Otherwise, reduce the hook parsing policy ? One of the two solution will give you a more integrated/consolidated project.

Best regards

Great work

[julien@…]

Screen shot of the rendering in the auto generated comment

[julien@…]

Screen shot of the rendering in TortoiseSVN

[Emmanuel Blot]

Replying to julien@…:

Otherwise, reduce the hook parsing policy ?

Commit hook scripts are located in the /contrib directory to indicate that they are not part of the Trac project. Actually, they should be considered as a base to implement your own hook scripts, depending on the way you use Trac+SVN in your team.

It should be quite straightforward to remove the extra syntax from the hook scripts so that they only accept the TracLinks format.

[Christian Boos]

Replying to eblot:

It should be quite straightforward to remove the extra syntax from the hook scripts so that they only accept the TracLinks format.

Right, and there's even an example for Revision and Changeset that can be adaptaed to Issue, Bug, etc.

See source:tags/trac-0.11/sample-plugins/revision_links.py​