Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

#789 closed defect (fixed)

[merge] cleanup scrollbar_position

Reported by: tonib Owned by: Christopher Lenz
Priority: low Milestone: 0.8
Component: wiki system Version: 0.7.1
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description (last modified by Christopher Lenz)

Added patch that cleans up the scroll_bar_position code in wiki.cs a little bit more. It also worked in IE under Wine.

Best regards,

Toni

Attachments (1)

patch.diff (3.0 KB ) - added by tonib 15 years ago.

Download all attachments as: .zip

Change History (8)

by tonib, 15 years ago

Attachment: patch.diff added

comment:1 by Christopher Lenz, 15 years ago

Owner: changed from Jonas Borgström to Christopher Lenz

comment:2 by Christopher Lenz, 15 years ago

Status: newassigned

comment:3 by Christopher Lenz, 15 years ago

Milestone: 0.8

If I read the patch correctly, it also removes support for setting the selection start/end in Gecko-based browsers. Why?

comment:4 by tonib, 15 years ago

Since when doing preview you will set focus on the preview text. This means that the selection text will be dissappear. And when you click on the textarea it the selection doesnt exist anymore. So no reason to have it, since it doesnt work.

comment:5 by tonib, 15 years ago

If one wants to keep the selection start/end code. I think the proper way of doing it is to use the javascript function onFocus and onBlur to save and reload the cursor setting. In addtion saving it when doing preview.

/T

comment:6 by Christopher Lenz, 15 years ago

Just a note: the selection is preserved on Mozilla-based browsers even if we pass focus to the preview. It's just that you need to tab back into <textarea></textarea> instead of clicking in it, as the latter will indeed reset the selection range.

Maybe we should remove the jump to the preview anchor after all?

comment:7 by Christopher Lenz, 15 years ago

Component: generalwiki
Description: modified (diff)
Priority: normallow
Resolution: fixed
Severity: normalminor
Status: assignedclosed

Fixed in [994].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.