Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#7858 closed enhancement (wontfix)

Partial Translation in Trac 0.11.1 (source code + templates)

Reported by: olemis@… Owned by:
Priority: normal Milestone:
Component: general Version: 0.11.1
Severity: normal Keywords: I18N, L10N
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Trac I18N is being implemented right now, and it will be ready for 0.12. You people have made a great work in order to mark localizable strings (comment based on 0.11.1).

While building a simple solution to Trac<0.12 I18N I realized that the site was not fully translated. I tried it with a Spanish translation I made on my own and many messages (specially in query and ticket templates …) were still displayed in english (… instead of spanish :( ).

Since the problem is not bound to a specific locale, I submit a patch so as to let you know what I did in order to render all these pages correctly. It fixes some «gaps» I found in Genshi templates as well as source code strings.

As long as I keep finding such «gaps» I will submit newer versions for this patch. Trac 0.11.1 will always be considered as the initial state for every diff.

Attachments (3)

i18n_udiff.patch (9.4 KB ) - added by olemis@… 15 years ago.
The aforementioned patch ;)
i18n_udiff.2.patch (6.4 KB ) - added by olemis@… 15 years ago.
The aformentioned attachment ;)
i18n_udiff.3.patch (6.4 KB ) - added by olemis@… 15 years ago.
The aformentioned attachment —-fixed— i.e. do not use the one formerly submitted ;)

Download all attachments as: .zip

Change History (6)

by olemis@…, 15 years ago

Attachment: i18n_udiff.patch added

The aforementioned patch ;)

comment:1 by olemis@…, 15 years ago

Sorry, I forgot to say that it is necessary to include some other messages (not found in either the source code nor any template) in the resulting POT files. They can be found in the main POT file I have prepared already. They are preceeded by a comment similar to #: Missing. Consider the following example:

#: Missing
#: trac/ticket/web_ui.py:1065
msgid "Assign to"
msgstr ""

by olemis@…, 15 years ago

Attachment: i18n_udiff.2.patch added

The aformentioned attachment ;)

by olemis@…, 15 years ago

Attachment: i18n_udiff.3.patch added

The aformentioned attachment —-fixed— i.e. do not use the one formerly submitted ;)

comment:2 by Christian Boos, 15 years ago

Resolution: wontfix
Status: newclosed

First, I can't see any reason why one couldn't upgrade from 0.11.x to 0.12 (trunk) if one wants i18n: the database scheme hasn't changed, the stability is the same, the functionality nearly identical except for a few welcomed enhancements, etc.

Second, the proposed patch has several flaws:

  • things like ${_(field.label)} etc. are wrong: such things don't make sense at extraction time; _() and such should only be called on extractable strings. If one wants to translate without extraction, one has to call gettext instead. But here, it's simply the field.label that has to be localized beforehand.
  • you added some translation markers that are already present in 0.12, which is another reason why it doesn't make sense to base your work on 0.11 at this point.

So I'm closing this ticket as wontfix, as we don't have any plans on making 0.11 localizable, as that's what 0.12 is there for.

That being said, there's a lot of effort still needed to make i18n work on trunk, so you're welcome to try to help there.

comment:3 by Remy Blank, 15 years ago

Milestone: 0.12

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none) to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.