[patch] Allow manage genshi.max_cache_size from ini file

[catalin.balan@…]

For custom templates, increasing the genshi's cache size improves performance.

From genshi docs:

...
The maximum number of templates that the template loader will cache in memory. 
The default value is 25. 
You may want to choose a higher value if your web site uses a larger number of templates, 
and you have enough memory to spare.
...

Thank you, Catalin Balan

[Christian Boos]

Though we already use [trac] auto_reload when actually speaking about templates, I think [trac] max_cache_size is too imprecise, we should rather have simply [trac] genshi_cache_size.

Also, could you please follow the TracDev/CodingStyle next time? (esp. wrapping lines at 79 chars).

[anonymous]

Replying to cboos:

Though we already use [trac] auto_reload when actually speaking about templates, I think [trac] max_cache_size is too imprecise, we should rather have simply [trac] genshi_cache_size.

Also, could you please follow the TracDev/CodingStyle next time? (esp. wrapping lines at 79 chars).

Sorry about 79 lines stuff.

In place of genshi_cache_size, I would rather have genshi.max_cache_size, genshi.auto_reaload and so on.

Thank you, Catalin Balan

[catalin.balan@…]

Maybe a dedicated section in config.

[genshi]
max_cache_size = 25
auto_reload = True

Thank you, Catalin Balan

[Remy Blank]

Patch applied in [8723], using [trac] genshi_cache_size as suggested in comment:1.

Incidentally, I noticed that auto_reload is an Option and not a BoolOption. With a default-generated trac.ini, the option is set to auto_reload = False, resulting in auto_reload = u'False' which evaluates as True… So it seems we have had auto-reloading active by default for a long time. I'll fix that in 0.11-stable and make a note on #7490 (even though it probably has only minimal impact).