Edgewall Software
Modify

Opened 12 years ago

Closed 12 years ago

Last modified 6 years ago

#7791 closed defect (fixed)

Don't allow tickets to be reassigned to completed/closed milestones

Reported by: mongoose643 Owned by: Remy Blank
Priority: normal Milestone: 0.11.3
Component: roadmap Version: 0.10.4
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

When on the "Edit Milestone" page and you are ready to reassign a leftover tickets to a new milestone you see a list of every milestone every created.

This list should be reduced to open milestones and not include past milestones that have been marked as complete.

Attachments (1)

7791-milestone-grouping-r7763.patch (9.0 KB ) - added by Remy Blank 12 years ago.
Patch against 0.11-stable grouping milestones on milestone edit and milestone delete pages

Download all attachments as: .zip

Change History (6)

comment:1 by Remy Blank, 12 years ago

Milestone: 0.11.20.11.3
Owner: set to Remy Blank

Sorry, no more tickets for 0.11.2.

comment:2 by Christian Boos, 12 years ago

We could eventually use the same logic here as in the ticket view and edit pages, i.e. show only the open milestones, except for TICKET_ADMIN (see #1440).

by Remy Blank, 12 years ago

Patch against 0.11-stable grouping milestones on milestone edit and milestone delete pages

comment:3 by Remy Blank, 12 years ago

The patch above groups the milestones in the select boxes of the milestone edit and delete pages, in the same way as the ticket edit page. It only shows completed milestones if the user has TICKET_ADMIN permission.

I'm not sure about how to check this, however. Currently, I use the following:

'TICKET_ADMIN' in req.perm(milestone.resource)

That is, I check for TICKET_ADMIN on the milestone. On the ticket edit page, the check is on the ticket itself, but this doesn't apply here, as there are several tickets to be modified, and checking the permission on all of them seems overkill. Should I rather do the following?

'TICKET_ADMIN' in req.perm

That's what the admin module does.

comment:4 by Remy Blank, 12 years ago

Component: admin/webroadmap
Resolution: fixed
Status: newclosed

Fixed in [7772]. I finally used the following to check for TICKET_ADMIN permission:

'TICKET_ADMIN' in req.perm

comment:5 by Ryan J Ollos, 6 years ago

In #11892 I propose moving grouped_milestones to the trac.ticket.roadmap module. Any feedback on the proposed change is appreciated.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.