Don't allow tickets to be reassigned to completed/closed milestones

[mongoose643]

When on the "Edit Milestone" page and you are ready to reassign a leftover tickets to a new milestone you see a list of every milestone every created.

This list should be reduced to open milestones and not include past milestones that have been marked as complete.

[Remy Blank]

Sorry, no more tickets for 0.11.2.

[Christian Boos]

We could eventually use the same logic here as in the ticket view and edit pages, i.e. show only the open milestones, except for TICKET_ADMIN (see #1440).

[Remy Blank]

Patch against 0.11-stable grouping milestones on milestone edit and milestone delete pages

[Remy Blank]

The patch above groups the milestones in the select boxes of the milestone edit and delete pages, in the same way as the ticket edit page. It only shows completed milestones if the user has TICKET_ADMIN permission.

I'm not sure about how to check this, however. Currently, I use the following:

'TICKET_ADMIN' in req.perm(milestone.resource)

That is, I check for TICKET_ADMIN on the milestone. On the ticket edit page, the check is on the ticket itself, but this doesn't apply here, as there are several tickets to be modified, and checking the permission on all of them seems overkill. Should I rather do the following?

'TICKET_ADMIN' in req.perm

That's what the admin module does.

[Remy Blank]

Fixed in [7772]. I finally used the following to check for TICKET_ADMIN permission:

'TICKET_ADMIN' in req.perm

[Ryan J Ollos]

In #11892 I propose moving grouped_milestones to the trac.ticket.roadmap module. Any feedback on the proposed change is appreciated.