Milestone completion time not shown when editing milestone

[ebray]

When marking a milestone as completed the current date is shown but not the current time.

Likewise, when editing an existing milestone the date is displayed by not the time. And on the roadmap page, only the milestone's completion date is shown.

This is just a simple matter of changing some formate_dates to format_datetime.

[Remy Blank]

Replying to ebray:

And on the roadmap page, only the milestone's completion date is shown.

I suppose this one is by design, as the hour doesn't give much additional information in an overview page anyway.

This is just a simple matter of changing some formate_dates to format_datetime.

Do you happen to know exactly which ones? Would save me the time to find out by myself :-)

[ebray]

Well, at least this much ought to be changed:

trac/ticket/templates/milestone_edit.html

@@ -62 +62 @@
             <label>
               <input type="text" id="completeddate" name="completeddate"
                      size="${len(datetime_hint)}" title="Format: ${datetime_hint}"
-                     value="${format_date(milestone.completed) or format_date}" />
+                     value="${format_datetime(milestone.completed)}" />
               <em>Format: ${datetime_hint}</em>
             </label>
             <py:if test="milestones">

That or format_date bit doesn't even make sense. (Maybe it was supposed to be format_date()?) It doesn't matter because if the milestone isn't completed, milestone.completed will resolve to None.

[Christian Boos]

Annotate shows it's a mistake coming from [3935/sandbox/datetime-genshi/trac/ticket/templates/milestone_edit.html]: it used to be datetime_now.

We could use format_date(datetime.now()).

(Note: the [3935/trunk/trac/ticket/templates/milestone_edit.html] link produces an error which is another symptom of #7744)

[ebray]

What I'm saying though is that it's not necessary to explicitly call datetime.now() because it's already built into to_datetime(), and by extension format_datetime() when it's passed None as its first argument. So as it is in the above diff works as expected—gives the current date/time if the milestone isn't already completed. Not that it's a big deal—you could always just as well be more explicit.

[Christian Boos]

You're right, no need for the or.

[Christian Boos]

Patch applied in [7623].

[Remy Blank]

Replying to cboos:

Patch applied in [7623].

Err… I think what Erik was asking to fix was to insert the date and the time instead of the date only, i.e. use format_datetime() instead of format_date(). This changeset doesn't address this.

[Christian Boos]

Replying to rblank:

Replying to cboos:

Patch applied in [7623].

Err… I think what Erik was asking to fix was to insert the date and the time instead of the date only, i.e. use format_datetime() instead of format_date(). This changeset doesn't address this.

Right, I just addressed the "at least" part of comment:2.

As one can specify the date and time for the milestone completed field, I think we should show it. Probably not on the Roadmap page, is it's just an overview, but the Milestone page itself should show the detail.

See also related #6369, discussing doing the same (setting date and time) for the due field.

[Christian Boos]

Fixed in r7638.