[PATCH] Trac does not send object names in quotes to PostgreSQL

[devrim@…]

Hello,

If we create an environment with a dash sign in it, Trac fails to authenticate from PostgreSQL. The reason is that within PostgreSQL, object names cannot have - in it:

test=# CREATE TEMP TABLE t-1 (c1 int);
ERROR:  syntax error at or near "-"
LINE 1: CREATE TEMP TABLE t-1 (c1 int);

If you want to use dash, you need to double quote object name:

test=# CREATE TEMP TABLE "t-1" (c1 int);
CREATE TABLE

This is not a bug — this is a feature. So trac needs to send all object names in double quotes to PostgreSQL.

Regards, Devrim

[felix.schwarz@…]

This problem is present even in 0.11 and trunk. I attach a patch which solves the problem for me. As I did not find any unit tests in trac for testing SQL generation for specific databases, I don't attach a test case.

[felix.schwarz@…]

patch against 0.11

[felix.schwarz@…]

re-did my patch, this time with unit tests

[felix.schwarz@…]

modifying subject to make my patch more visible

[Christian Boos]

Patch looks OK, would need some double checking before applying.

Postponing to 0.11.3 but if someone feels like testing and applying it before, please do.

[Jonas Borgström]

Patch applied in [7784] and [7785]. Thanks Felix!

[shanec@…]

This patch broke index creation with postgres 8.3 on both osx and linux. You cannot do quoting as follows:

CREATE INDEX "tags_tagspace_name_idx" ON "tags" ("tagspace,name")

It needs to be:

CREATE INDEX "tags_tagspace_name_idx" ON "tags" ("tagspace", "name")

at this point, 11.3 is busted for creating projects using postgres.

Patch to follow.

[shanec@…]

fix for index column quoting

[Christian Boos]

Jonas, looks like a candidate for 0.11.3.1, as it fixes a defect introduced in 0.11.3?

[Felix Schwarz <felix.schwarz@…>]

a test case to ensure that the bug does not creep in again

[Christian Boos]

Thanks for the patches.

[Eli Carter]

Based on a bug report on IRC, a fix for this is in r7923 and r7924 (done before I knew about this bugreport), but does not include testcases.

[Jonas Borgström]

Test case patch applied in [7938].

This changeset also includes the postgresql test cases in the main test suite. As far as I can tell this should be safe and work even if no postgresql module is available.