expand_dir.js is buggy on table layouts

[Pedro Algarvio, aka, s0undt3ch]

When creating a custom template to trac I found out that expand_dir.js​ show's buggy behaviour on table layouts.

When looking for parents, the script should only use the first one found, not all parents().

Here's a patch:

trac/htdocs/js/expand_dir.js

@@ -40 +40 @@
 
   // handler for click event on the expander icons
   window.toggleDir = function(expander, qargs) {
-    var tr = expander.parents("tr");
+    var tr = expander.parents("tr:first");
     var folderid = tr.get(0).id;
 
     if ( tr.filter(".expanded").length ) { // then *fold*

Yes, I know table layouts should be avoided, but that's not the issue here, the issue is making the script work better/as expected.

[Christian Boos]

Requested again in #7634…

[Christian Boos]

Suggested fix applied in r7543.

[Martin.vGagern@…]

How about the expander.parents("td") in the fetch part of the function? I guess that this should receive the same treatment.

Are there any plans to merge this fix into 0.11-stable?

[Christian Boos]

The milestone says 0.11.2, but apparently this was only committed on trunk.

[Christian Boos]

Fixed by r8728 and r8729 on 0.11.6dev.

The second was propagated on trunk part of r8730.

[Martin.vGagern@…]

Thanks a lot!