Malformed URLs in revision logs?

[Jennifer Drummond <jenn@…>]

I'm getting a traceback when I try to view a changeset from the list of revisions in the Trac SVN browser. Simple URLs like the wiki generates (/changeset/12345) work fine, but from the browser I'm getting URLs like /changeset/12345/testing, which give the error.

How to Reproduce

To reproduce (with examples from my system):

• Click "Browse Source": /browser.
• Click an SVN module ("testing", in my case): /browser/testing
• Click the "Revision log" link: /log/testing
• Click one of the links in the "Chgset" column: /changeset/23720/testing

That last page is the one that breaks.

Stuff stuck in automatically by the error-reporting link

While doing a GET operation on /changeset/23720/testing, Trac issued an internal error.

Request parameters:

{'new': u'23720', 'new_path': u'/testing'}

User Agent was: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16

System Information

Trac	0.11
Python	2.4.4 (#1, Apr 5 2007, 20:09:06) [GCC 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)]
setuptools	0.6c3
psycopg2	2.0.5.1 (dec mx dt ext pq3)
Genshi	0.5
mod_python	3.2.10
Subversion	1.4.2 (r22196)
jQuery:	1.2.3

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/Trac-0.11-py2.4.egg/trac/web/main.py", line 423, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/Trac-0.11-py2.4.egg/trac/web/main.py", line 197, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/Trac-0.11-py2.4.egg/trac/versioncontrol/web_ui/changeset.py", line 323, in process_request
    self._render_html(req, repos, chgset, restricted, xhr, data)
  File "/usr/lib/python2.4/site-packages/Trac-0.11-py2.4.egg/trac/versioncontrol/web_ui/changeset.py", line 414, in _render_html
    next_rev = repos.next_rev(chgset.rev, path)
  File "/usr/lib/python2.4/site-packages/Trac-0.11-py2.4.egg/trac/versioncontrol/cache.py", line 254, in next_rev
    return self._next_prev_rev('>', rev, path)
  File "/usr/lib/python2.4/site-packages/Trac-0.11-py2.4.egg/trac/versioncontrol/cache.py", line 265, in _next_prev_rev
    sql += " AND (path %s OR " % self.db.like()
AttributeError: 'CachedRepository' object has no attribute 'db'

[Jennifer Drummond <jenn@…>]

rblank ​suggested that I upgrade to 0.11.1, and the long link form does work there.

That's a little odd, since I was expecting the URLs to change to the simple form, rather than for the extended form to start working. If I'm going through the revision log at /log/[somemodule]/branches/[branchname]/[filename] and I click on a revision number, I want to see the whole changeset, not just the changes to [filename]; I see a changeset link as a sort of "drill up". If I want to see just that one specific file, I can use the revision link right next to the changeset link.

If someone can explain that rationale to me, I'd appreciate it. Leaving this ticket open since I don't know what the protocol is for closing bugs that are already fixed in subsequent versions.

[Remy Blank]

Replying to Jennifer Drummond <jenn@…>:

If I'm going through the revision log at /log/[somemodule]/branches/[branchname]/[filename] and I click on a revision number, I want to see the whole changeset, not just the changes to [filename]; I see a changeset link as a sort of "drill up". If I want to see just that one specific file, I can use the revision link right next to the changeset link.

I guess both can be useful. When viewing the changeset for a file, you can see that the changeset number in the title is a link to the complete changeset, so what you want is really only one click away.

Leaving this ticket open since I don't know what the protocol is for closing bugs that are already fixed in subsequent versions.

I'll close it as "invalid".