Modify ↓
Opened 16 years ago
Closed 16 years ago
#7516 closed defect (fixed)
Error in comment header of contrib/trac-post-commit-hook
Reported by: | Owned by: | Jonas Borgström | |
---|---|---|---|
Priority: | low | Milestone: | 0.11.2 |
Component: | general | Version: | 0.11.1 |
Severity: | normal | Keywords: | trac-post-commit-hook contrib |
Cc: | Branch: | ||
Release Notes: | |||
API Changes: | |||
Internal Changes: |
Description
There's a bug in the trac-post-commit-hook header (at least in 0.11.1 and 0.11). It says that the post-commit file should contain:
REPOS="$1" REV="$2" /usr/bin/python /usr/local/src/trac/contrib/trac-post-commit-hook -p "$TRAC_ENV" -r "$REV"
When obviously (at least in hindsight!) it should be:
REPOS="$1" REV="$2" /usr/bin/python /usr/local/src/trac/contrib/trac-post-commit-hook -p "$REPOS" -r "$REV"
Attachments (0)
Change History (5)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Milestone: | → 0.11.2 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Ok added in [7453], thanks.
comment:3 by , 16 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:4 by , 16 years ago
Owner: | set to |
---|---|
Status: | reopened → new |
Note:
See TracTickets
for help on using tickets.
My mistake. Looks like the line in question is correct:
However, the TRAC_ENV isn't defined, as it is in trac-pre-commit-hook. So I think the following line is missing from the comment header:
# TRAC_ENV="/somewhere/trac/project/"