Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

#7516 closed defect (fixed)

Error in comment header of contrib/trac-post-commit-hook

Reported by: stodge@… Owned by: Jonas Borgström
Priority: low Milestone: 0.11.2
Component: general Version: 0.11.1
Severity: normal Keywords: trac-post-commit-hook contrib
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

There's a bug in the trac-post-commit-hook header (at least in 0.11.1 and 0.11). It says that the post-commit file should contain:

REPOS="$1"
REV="$2"
/usr/bin/python /usr/local/src/trac/contrib/trac-post-commit-hook -p
"$TRAC_ENV" -r "$REV"

When obviously (at least in hindsight!) it should be:

REPOS="$1"
REV="$2"
/usr/bin/python /usr/local/src/trac/contrib/trac-post-commit-hook -p
"$REPOS" -r "$REV"

Attachments (0)

Change History (5)

comment:1 by stodge@…, 16 years ago

My mistake. Looks like the line in question is correct:

/usr/bin/python /usr/local/src/trac/contrib/trac-post-commit-hook -p
"$TRAC_ENV" -r "$REV"

However, the TRAC_ENV isn't defined, as it is in trac-pre-commit-hook. So I think the following line is missing from the comment header:

# TRAC_ENV="/somewhere/trac/project/"

comment:2 by Jonas Borgström, 16 years ago

Milestone: 0.11.2
Resolution: fixed
Status: newclosed

Ok added in [7453], thanks.

comment:3 by Christian Boos, 16 years ago

Resolution: fixed
Status: closedreopened

comment:4 by Christian Boos, 16 years ago

Owner: set to Jonas Borgström
Status: reopenednew

comment:5 by Christian Boos, 16 years ago

Resolution: fixed
Status: newclosed

fixing owner

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.