No diff shown in changeset view even with FILE_VIEW permission

[nick@…]

If a user is created with CHANGESET_VIEW and FILE_VIEW permissions I would expect them to be able to see diffs in the changeset view, view the list of any changed files, along with being able to follow the link to the files themselves. Currently you can only see these items if you also have the BROWSER_VIEW permission.

I've attached a patch, produced against trunk r7444, which produces the behaviour I expected.

If this isn't the desired behaviour, would it be possible to update the documentation to highlight the current behaviour? I spent a while trying to figure out why anonymous users couldn't see files in the changeset, even when the, apparently, appropriate permissions were set, and think it would prevent other people from encountering the same issue.

This behaviour was introduced in r3384 by a patch from issue #2268.

[nick@…]

Fixes behaviour highlighted in ticket #7507

[osimons]

Need to look into this and assess the impact of the problem and the proposed change.

Tentatively scheduling for 0.11-stable (as a regression-type bug), but if it constitues a change from established working behaviour it should be 0.12 at the earliest.

[Remy Blank]

This should be fixed on trunk with the recent authz changes. Please reopen if you find any issues with current trunk.