Context Navigation

Modify ↓

#7469 closed defect (fixed)

Reported by:	Pedro Algarvio, aka, s0undt3ch	Owned by:	Jeroen Ruigrok van der Werven
Priority:	highest	Milestone:	0.12
Component:	general	Version:	0.12dev
Severity:	blocker	Keywords:
Cc:		Branch:
Release Notes:
API Changes:
Internal Changes:

The correct refactoring would have been:

                 translation.get_available_locales()]
             preferred = req.session.get('language', req.languages)
             if isinstance(preferred, list):
+            if not isinstance(preferred, list):
                 preferred = [preferred]
             return Locale.negotiate(preferred, available, sep='-')

Owner:	set to Jeroen Ruigrok van der Werven

Resolution:	→ fixed
Status:	new → closed

Fixed in r7412. Thanks.

Resolution:	fixed
Status:	closed → reopened

Resolution:	→ fixed
Status:	reopened → closed

Change Properties

Summary:
Description:	The correct refactoring would have been: {{{ #!diff Index: trac/web/main.py =================================================================== --- trac/web/main.py (revision 7409) +++ trac/web/main.py (working copy) @@ -276,7 +276,7 @@ translation.get_available_locales()] preferred = req.session.get('language', req.languages) - if isinstance(preferred, list): + if not isinstance(preferred, list): preferred = [preferred] return Locale.negotiate(preferred, available, sep='-') }}} You may use WikiFormatting here.
Type:		Priority:
Milestone:		Component:
Version:		Severity:
Keywords:		Cc:	Set your email in Preferences
Branch:
Release Notes:
API Changes:
Internal Changes:

Action

leave as closed The owner will remain Jeroen Ruigrok van der Werven.

reopen The resolution will be deleted. Next status will be 'reopened'.

change ownership to The owner will be changed from Jeroen Ruigrok van der Werven to the specified user.

Your email or username:

E-mail address and name can be saved in the Preferences .

You may use WikiFormatting here.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.