[patch] The md5 module is deprecated in python, use hashlib instead

[mad]

Hello,

the md5 module is deprecated, hashlib should be used instead. here is a simple patch against 0.11 to kill the warnings.

[mad]

patch to replace the usage of the depecated md5 module with hashlib

[Noah Kantrowitz]

This is not possible without dropping support for Python 2.4. Not going to happen for a while.

[Emmanuel Blot]

It could be implemented with compatibility for previous release of Python:

try:
    import hashlib
    md = hashlib.md5()
except ImportError:
    # for Python << 2.5
    import md5
    md = md5.new()

[mad]

the patch was wrong in some way, with it applied the login href was missing. strange…

[Remy Blank <remy.blank@…>]

Yes, the search and replace was a bit too hasty. I would guess that the substitution at line 38 of trac/web/auth.py is wrong.

[mad]

Updated version with sha module replacement and fixed login href

[Remy Blank <remy.blank@…>]

Patch against 0.11-stable that implements the solution suggested by eblot

[Remy Blank <remy.blank@…>]

The patch above imports either hashlib.md5 or md5.md5 into trac.util, and all users of md5 import it from there.

The same import hack is applied separately to contrib/htdigest.py so that it doesn't have to depend on trac.util.

The patch proposed by mad also fixed trac/wiki/default-pages/TracStandalone, but I understand these pages are imported from the live Trac instance on t.e.o during the release process. So I'll patch TracStandalone with the same hack.

[Christian Boos]

attachment:7458-hashlib-r7376.patch​ looks great, I'll apply it later today.

[Christian Boos]

Applied with minor tweaking in (moved the hashlib import logic in trac.util.compat, where we usually place this sort of things). It's still importable directly from trac.util though.

Patch applied in r7384.

[mad]

I've upgraded my Trac environment to 0.11.2 today and everything is running on Python 2.6 here. I got some errors about the deprecation of module sha which i fixed myself on 0.11 as shown in my last patch… I've updated my patch to 0.11.2 and fixed the comments to blame python version 2.6 and not 2.5 which was wrong.

[mad]

Updated patch to get rid of deprecation warnings

[Remy Blank]

That's true, we should have done both at the same time. The md5 and sha modules are actually deprecated since 2.5 (see the docs), but they only started generating a warning in 2.6.

[mad]

Fixed patch to metion the right python version

[mad]

Please scratch my last patch and please take a look here:

​http://docs.python.org/whatsnew/2.6.html

The actual deprecation is listed in the docs of Python 2.6 The hashlib module itself was just added in version 2.5

[Remy Blank]

It's really only a detail, but look at the top of:

​http://www.python.org/doc/2.5.2/lib/module-sha.html

Anyway, I'm waiting for 0.11.2.1 to be out, then I'll fix the deprecation. Thanks for reporting the success with 2.6.

[mad]

the two sides of the same medal ;)

to be clear, we faced no problems with trac-0.11 on python 2.6 even the actual trac-0.11 branch of bitten works like a charm here.

thanks for providing such a good environment for our development.

[Remy Blank]

Fixed in [7696].

[jevans]

I see these warnings in Trac 0.11.4 trac-admin with Python 2.6. Should that be a separate ticket?

[jevans]

Replying to jevans:

I see these warnings in Trac 0.11.4 trac-admin with Python 2.6. Should that be a separate ticket?

Sorry, they appear to come from AccountManager.