Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

#7444 closed enhancement (fixed)

[PATCH] Searching in milestones

Reported by: Remy Blank <remy.blank@…> Owned by: remy.blank@…
Priority: normal Milestone: 0.11.1
Component: roadmap Version:
Severity: normal Keywords: milestone patch
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The search function currently doesn't search in milestones. The attached patch adds an ISearchSource to MilestoneModule and allows searching in the milestone name and description.

The patch depends on #2561 for searching in milestone attachment metadata as well. Should the former not be accepted, the last section starting with the # Attachments comment can simply be dropped.

Attachments (2)

milestone-search.patch (2.3 KB ) - added by Remy Blank <remy.blank@…> 16 years ago.
Patch against 0.11-stable [7346] adding searching in milestones
search-no-author.patch (661 bytes ) - added by Remy Blank <remy.blank@…> 16 years ago.
Do not show author in search results if it is empty

Download all attachments as: .zip

Change History (8)

by Remy Blank <remy.blank@…>, 16 years ago

Attachment: milestone-search.patch added

Patch against 0.11-stable [7346] adding searching in milestones

comment:1 by Remy Blank <remy.blank@…>, 16 years ago

A few comments:

  • The author field of milestone search results is set to the empty string. This is consistent with the data returned for timeline events. However, for milestone events in the timeline, the author is not displayed at all, whereas in search results, the author appears as anonymous. Maybe this should be fixed in the search template in the same way as in the timeline.
  • The time field of milestone search results is set to the completed date if it is set, otherwise to the due date if it is set, otherwise to "now". I'm not quite sure about this last case, but setting it to 0 makes all milestones with no due or completed date come last, as the search result list is sorted in descending time order. And setting it to an arbitrary date in the future (e.g. in 1 month) doesn't sound convincing either.

by Remy Blank <remy.blank@…>, 16 years ago

Attachment: search-no-author.patch added

Do not show author in search results if it is empty

comment:2 by Christian Boos, 16 years ago

<py:if test="result.author"><span class="author">...

can also be written:

<span py:if="result.author" class="author">...

comment:3 by Remy Blank <remy.blank@…>, 16 years ago

Not if you include the &mdash; at the end of the line ;-)

But apart from that, does it make sense to remove the author when it is empty, or does some other functionality rely on it being there?

in reply to:  3 comment:4 by Christian Boos, 16 years ago

Replying to Remy Blank <remy.blank@pobox.com>:

Not if you include the &mdash; at the end of the line ;-)

Morning reviewing not a good thing ;-)

But apart from that, does it make sense to remove the author when it is empty, or does some other functionality rely on it being there?

I think it's OK to remove it.

comment:5 by Christian Boos, 16 years ago

Milestone: 0.11.1
Owner: set to remy.blank@…

0.11.1, as any other minor release, is "Bug fixes and minor improvements to 0.11.", so I think this feature (as well as #2561) is fine for being included there.

comment:6 by Christian Boos, 16 years ago

Resolution: fixed
Status: newclosed

Both patches applied, in [7351] and [7352].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain remy.blank@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from remy.blank@… to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.