Edgewall Software

Opened 14 years ago

Closed 14 years ago

#7431 closed defect (fixed)

E-mail obfuscation again - Replying to ticket comments

Reported by: osimons Owned by: osimons
Priority: normal Milestone: 0.11.1
Component: ticket system Version: 0.11-stable
Severity: normal Keywords: notification
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


When replying to ticket comments, even though the user does not have e-mail view permission, the e-mail of the user/session will be available in comment-link header of the text copied as >.

Attachments (0)

Change History (5)

comment:1 by osimons, 14 years ago

Component: generalticket system

comment:2 by anonymous, 14 years ago

Keywords: notification added

comment:3 by osimons, 14 years ago

Like #6532 the content becomes part of the content itself for viewing and notification, and it cannot really depend on the permissions of the user making the change. As we don't obfuscate labels in links, the actual e-mail will be available for all to see.

Easy solution is simply doing obfuscation as default behaviour in all cases:

  • trac/ticket/web_ui.py

    11241124        def quote_original(author, original, link):
    11251125            if 'comment' not in req.args: # i.e. the comment was not yet edited
    11261126                data['comment'] = '\n'.join(
    1127                     ['Replying to [%s %s]:' % (link, author)] +
     1127                    ['Replying to [%s %s]:' % (link,
     1128                                        obfuscate_email_address(author))] +
    11281129                    ['> %s' % line for line in original.splitlines()] + [''])
    11301131        if replyto == 'description':

The other option would be to make the obfuscation conditional on permission, but in addition obfuscate all link labels in the wiki formatter used by all parts of Trac for rendering of wiki markup. This will be more complex, and will of course still leave pre-obfuscated labels anyway for all those that reply without permission.

The cleanest would be to always obfuscate the auto-generated label. It is just a label, and to make it even simpler we could also drop the author and just do like Replying to [comment:14]:.

Comments or better suggestions?

comment:4 by Christian Boos, 14 years ago

I'm OK with the proposed change. Only having "replying to <num>" would go too far, IMO.

in reply to:  4 comment:5 by anonymous, 14 years ago

Resolution: fixed
Status: newclosed

Oki. Committed to 0.11-stable in [7366] and merged to trunk in [7367].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from osimons to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.