Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

#7403 closed defect (fixed)

TicketQuery "format=table" generates bad table header links

Reported by: Jason Winnebeck <jpwasp@…> Owned by: Christian Boos
Priority: normal Milestone: 0.11.1
Component: ticket system Version: 0.11
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

[[TicketQuery(status!=closed,summary^=PPR,max=0,order=id,format=table)]] generates bad links on the table header. It generates a link (for example on the "summary" header) to https://<MyTracSite>/query?status=%21closed&max=0&summary=%5EPPR&order=summary&page=0. When clicking the link, up comes a Trac error "Query page 0 is invalid." If I manually change the link in my browser to page=1, it works.

My opinion is that either having it link to page=1 (so that clicking goes to a query page), or not having any links at all (because it's a "static" query in the page) would be good possible solutions. I didn't suggest that the query macro could update in the page itself (i.e. the actual wiki page refreshes with the new order), as I figure that would be a very difficult task (esp with multiple TicketQuery per page) with not a lot of benefit.

(0.11-stable r7295)

Attachments (1)

7403-TicketQuery-page-0-r7294.diff (2.4 KB ) - added by Christian Boos 16 years ago.
Fix the page=0 issue + some cleanups

Download all attachments as: .zip

Change History (5)

comment:1 by Christian Boos, 16 years ago

Owner: set to Christian Boos

Thanks for the report, I'll look into this one as well.

by Christian Boos, 16 years ago

Fix the page=0 issue + some cleanups

comment:2 by Christian Boos, 16 years ago

Please try out the above patch.

comment:3 by Jason Winnebeck <jpwasp@…>, 16 years ago

It appears to be working, actually in the generated URL I don't see a page parameter at all anymore.

comment:4 by Christian Boos, 16 years ago

Resolution: fixed
Status: newclosed

Thanks for the feedback Jason.

Fix committed as [7305].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.