[PATCH] Filesize less than original when downloading file under SSL

[zoltan.kovacs@…]

When using Trac under HTTPS connection, the files downloaded using the send_file() function from apy.py has differ from original. The solution is to add 'Pragma: no-cache' header to the function.

[zoltan.kovacs@…]

I cannot add attachment to ticket (internal trac error - UnicodeDecode), so I copy the patchfile to here:

Index: api.py
===================================================================
--- api.py      (revision 7274)
+++ api.py      (working copy)
@@ -386,6 +386,7 @@
                        'application/octet-stream'

         self.send_response(200)
+       self.send_header('Pragma', 'no-cache')
         self.send_header('Content-Type', mimetype)
         self.send_header('Content-Length', stat.st_size)
         self.send_header('Last-Modified', last_modified)

Replying to zoltan.kovacs@unitechnal.ch:

When using Trac under HTTPS connection, the files downloaded using the send_file() function from apy.py has differ from original. The solution is to add 'Pragma: no-cache' header to the function.

[Remy Blank]

I don't understand what the issue is. Do you mean that you can upload an attachment using HTTPS, and when you download it back, it differs from the original?

Could you please provide step-by-step instructions to reproduce the issue? Also specify the versions of the various components of your Trac installation, and what handler you use (tracd, mod_python, mod_wsgi).

[anonymous]

I guess when downloading a version of an already existing file, then uploading a newer version and then downloading it again, the old version ist still "downloaded" from the local browser cache. I know that behaviour from various web sites.

[Remy Blank]

Isn't that what the Last-Modified header is designed to avoid? I think Trac sets it to the mtime of the attachment, which should get updated when the attachment is replaced.

It is also strange that this only seems to happen with HTTPS connections.

[Christian Boos]

Replying to anonymous:

I guess when downloading a version of an already existing file, then uploading a newer version and then downloading it again, the old version ist still "downloaded" from the local browser cache.

That would be a bug, need to verify.

[Christian Boos]

No feedback provided to comment:2, closing.