Edgewall Software

Opened 14 years ago

Closed 13 years ago

Last modified 8 years ago

#7386 closed defect (fixed)

Trac fails on URIs

Reported by: erlehmann Owned by: Christian Boos
Priority: normal Milestone: 0.12
Component: wiki system Version:
Severity: normal Keywords: review, traclinks
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


Look at this link: <http://en.wikipedia.org/wiki/Mornington_Crescent_(game)> - it isn't highlighted correctly - the last bracket should be part of the URI. Now take <xmpp:erlehmann@jaim.at?roster> or <urn:isbn:0-345-33971-1>, which aren't highlighted at all.

A detailed solution with a proper regex that also matches links in parentheses can be found at <http://dieweltistgarnichtso.net/index.php?/archives/32-Constructing-a-regular-expression-that-matches-URIs.html#extended> .

Attachments (1)

t7386-alt-shref-r7606.diff (2.5 KB ) - added by Christian Boos 14 years ago.
Add alternative syntax for short links: <realm_or_protocol:target>

Download all attachments as: .zip

Change History (8)

in reply to:  description comment:1 by Remy Blank, 14 years ago

Milestone: 1.0

Replying to erlehmann:

Look at this link: (…)

And I actually clicked on the link, and thought "wtf?" :-)

We could indeed do better than the current state.

comment:2 by Christian Boos, 14 years ago

Component: web frontendwiki system
Keywords: traclinks added
Milestone: 1.00.12
Owner: set to Christian Boos

Strange that I didn't write anything on the ticket, as I have implemented it a while back after reading this ticket (or was it a duplicate?)

by Christian Boos, 14 years ago

Attachment: t7386-alt-shref-r7606.diff added

Add alternative syntax for short links: <realm_or_protocol:target>

comment:3 by Christian Boos, 14 years ago

Keywords: review added
Status: newassigned

No, the patch was actually targeting this ticket, sorry for not answering earlier.

comment:4 by Christian Boos, 13 years ago

Resolution: fixed
Status: assignedclosed

Patch applied in r8696.

comment:5 by Ryan J Ollos, 8 years ago

Keywords: traclinks review → traclinks, review

comment:6 by Ryan J Ollos, 8 years ago

Keywords: traclink added; traclinks removed

comment:7 by Ryan J Ollos, 8 years ago

Keywords: traclinks added; traclink removed

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.