#7386 closed defect (fixed)
Trac fails on URIs
| Reported by: | erlehmann | Owned by: | Christian Boos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | wiki system | Version: | |
| Severity: | normal | Keywords: | review, traclinks |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Look at this link: <http://en.wikipedia.org/wiki/Mornington_Crescent_(game)> - it isn't highlighted correctly - the last bracket should be part of the URI. Now take <xmpp:erlehmann@jaim.at?roster> or <urn:isbn:0-345-33971-1>, which aren't highlighted at all.
A detailed solution with a proper regex that also matches links in parentheses can be found at <http://dieweltistgarnichtso.net/index.php?/archives/32-Constructing-a-regular-expression-that-matches-URIs.html#extended> .
Attachments (1)
Change History (8)
comment:1 by , 17 years ago
| Milestone: | → 1.0 |
|---|
comment:2 by , 17 years ago
| Component: | web frontend → wiki system |
|---|---|
| Keywords: | traclinks added |
| Milestone: | 1.0 → 0.12 |
| Owner: | set to |
Strange that I didn't write anything on the ticket, as I have implemented it a while back after reading this ticket (or was it a duplicate?)
by , 17 years ago
| Attachment: | t7386-alt-shref-r7606.diff added |
|---|
Add alternative syntax for short links: <realm_or_protocol:target>
comment:3 by , 17 years ago
| Keywords: | review added |
|---|---|
| Status: | new → assigned |
No, the patch was actually targeting this ticket, sorry for not answering earlier.
comment:5 by , 12 years ago
| Keywords: | traclinks review → traclinks, review |
|---|
comment:6 by , 12 years ago
| Keywords: | traclink added; traclinks removed |
|---|
comment:7 by , 12 years ago
| Keywords: | traclinks added; traclink removed |
|---|
Replying to erlehmann:
And I actually clicked on the link, and thought "wtf?" :-)
We could indeed do better than the current state.