Edgewall Software

Opened 18 years ago

Closed 18 years ago

#738 closed defect (fixed)

Attachment author not populated from Settings and not escaped for HTML

Reported by: Matthew Good <matt-good.net> Owned by: Jonas Borgström
Priority: normal Milestone: 0.8
Component: general Version: 0.7.1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:


The author field for the attachment page is not populated with the user's information from Settings like it is for ticket and Wiki changes.

Also, the author is not escaped for HTML when displayed on the page, so when using the format used in other pages of "Name <email>" the email part gets hidden.

I have a patch which should resolve both of these problems. I used a variable 'attachment.author' in the hdf in order to remain consistent with the way things were being done now, however I think that since the information gotten from get_reporter_id is used in a variety of places it may be best to just make this a standard variable that can be accessed from the template rather than using storing it under different keys specific to each page.

Attachments (1)

attachment_author.patch (1.8 KB ) - added by Matthew Good <matt-good.net> 18 years ago.

Download all attachments as: .zip

Change History (2)

by Matthew Good <matt-good.net>, 18 years ago

Attachment: attachment_author.patch added


comment:1 by Jonas Borgström, 18 years ago

Resolution: fixed
Status: newclosed

Thanks, applied in [913].

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Jonas Borgström.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jonas Borgström to the specified user.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.