#7324 closed defect (fixed)
Firefox crashes when performing large quick search
| Reported by: | fermulator | Owned by: | Remy Blank | 
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.3 | 
| Component: | search system | Version: | 0.11b1 | 
| Severity: | normal | Keywords: | |
| Cc: | fermulator@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Steps to reproduce issue:
- Using Firefox…
 - Open a trac website.
 - Provided we have a ticket (semi-large) with several comments (20+).
 - Copy into the clipboard a sentence (15+ words) from a comment in said ticket.
 - In the quick search of trac, paste that large sentence and perform the search. … the results will be displayed … probably only the ONE result of that ticket since the sentence would probably be unique.
 - Click on the link to the ticket.
 
…
trac will cause firefox to use A LOT of CPU, and the ticket could take upwards of 2+ minutes to load. Yikes!
Sometimes even firefox will crash entirely …
We suspect this has to do with syntax highlighting javascript from trac itself.
Comparison:
- Do a quicksearch for the TICKET NUMBER (i.e. #999)
 - trac will automatically load the ticket, and it will be fast!
 
In the comparison case the only difference I can see is that there wouldn't be syntax highlighting … ?
Attachments (1)
Change History (7)
by , 17 years ago
| Attachment: | search-limit.diff added | 
|---|
comment:3 by , 17 years ago
| Milestone: | → 0.11.3 | 
|---|---|
| Owner: | changed from to | 
I can reproduce this issue in Firefox 2.0.0.17, for example using #31 and following the procedure provided in the ticket description. The browser never crashes, but I get the message box about "a script taking too long" several times before the page displays.
Limiting the number of highlights sounds like a good idea.
comment:4 by , 17 years ago
| Resolution: | → fixed | 
|---|---|
| Status: | new → closed | 
Fixed in [7695] by limiting highlighting to 10 terms, but also requiring terms to be at least 3 characters.
comment:6 by , 17 years ago
| Owner: | changed from to | 
|---|



  
Limit number of highlighted words on search