TypeError: previous_rev() takes exactly 2 arguments (3 given)

[guohq]

How to Reproduce

While doing a GET operation on /changeset/e6abab444daf80c87b1dcf85963d1e0f58c85dbb, Trac issued an internal error.

(please provide additional details here)

Request parameters:

{'new': u'e6abab444daf80c87b1dcf85963d1e0f58c85dbb'}

User Agent was: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11 GoogleToolbarFF GoogleToolbarFF

System Information

Trac	0.11rc1
Python	2.5.2 (r252:60911, Jun 1 2008, 14:31:20) [GCC 3.4.6]
setuptools	0.6c8
SQLite	3.5.7
pysqlite	2.4.1
Genshi	0.4.4
Pygments	0.10
GIT	1.5.5.1
jQuery:	1.2.3

Python Traceback

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11rc1-py2.5.egg/trac/web/main.py", line 417, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11rc1-py2.5.egg/trac/web/main.py", line 197, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11rc1-py2.5.egg/trac/versioncontrol/web_ui/changeset.py", line 323, in process_request
    self._render_html(req, repos, chgset, restricted, xhr, data)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11rc1-py2.5.egg/trac/versioncontrol/web_ui/changeset.py", line 406, in _render_html
    prev_rev = repos.previous_rev(chgset.rev)
  File "/usr/local/lib/python2.5/site-packages/Trac-0.11rc1-py2.5.egg/trac/versioncontrol/cache.py", line 241, in previous_rev
    return self.repos.previous_rev(rev, path)
TypeError: previous_rev() takes exactly 2 arguments (3 given)

[Christian Boos]

​TH:GitPlugin issue, ​TH:#3008 even.

[Jack Nguy]

I ran into the same issue using Perforce with Trac. I just changed return self.repos.previous_rev(rev, path) to return self.repos.previous_rev(rev) in Python\Lib\site-packages\Trac-0.12dev_r7452-py2.4.egg\trac\versioncontrol\cache.py and it appears to be working