Opened 17 years ago
Closed 16 years ago
#7293 closed enhancement (fixed)
support for dynamic variables in the report_view page
| Reported by: | Owned by: | Remy Blank | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | report system | Version: | |
| Severity: | normal | Keywords: | dynamicvar patch |
| Cc: | scratcher@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
After the discussion on this trac-dev thread I made a patch that displays a list of filters for every variable in a query.
The problem this patch resolves is encountered when a sql report has a variable defined and no values is passed in the URL. The patch allows the user to enter values for this variables.
Attachments (4)
Change History (12)
by , 17 years ago
| Attachment: | dynamic_variables.diff added |
|---|
by , 16 years ago
| Attachment: | 7293-report-argument-editor-r7493.patch added |
|---|
comment:1 by , 16 years ago
| Keywords: | patch added |
|---|---|
| Owner: | changed from to |
The patch above is a rework of the first patch attached (which was already very good):
- The layout of the argument fieldset was adapted to be as close to the custom query as possible.
- A warning lists missing arguments (if any).
- The folding JavaScript is not called if there are no arguments.
Fields are considered missing if they don't appear in the request at all. Empty arguments are considered present.
Comments?
comment:2 by , 16 years ago
| Cc: | added |
|---|
comment:3 by , 16 years ago
| Milestone: | → 0.12 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Patch applied in [7555], with a few fixes to report test cases, and an additional test case for missing arguments.
by , 16 years ago
| Attachment: | trac-report_args.diff added |
|---|
Enabling dynamic report arguments form for reports with only one argument
follow-up: 5 comment:4 by , 16 years ago
Hi,
Is there a reason why only reports with len(args)>1 should have the dynamic arguments form ? Check out the previous attached patch.
Sorry for the double post
Thank you, Catalin Balan
comment:5 by , 16 years ago
Replying to catalin.balan@…:
Is there a reason why only reports with len(args)>1 should have the dynamic arguments form ?
IIRC, there is always at least one argument, for the automatic $USER variable. So len(args) is always at least 1. It is >1 only when there are custom arguments.
Do you actually observe that the form is missing for a report with a single custom argument? I may have missed something.
comment:6 by , 16 years ago
Hey rblank,
AFAIK, there is also a method that clear args that are not used in the sql, so for queries that are using only one var, other then USER, the form is not showed.
Thank you, Catalin Balan
comment:8 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Right, I wasn't careful enough. Fixed in [7756]. Thanks for reporting the issue.
Patch against 0.11-stable adding editable fields for report arguments