Edgewall Software
Modify ↓

Opened 17 years ago

Closed 16 years ago

#7260 closed defect (fixed)

Unclickable Close button in Annotate message panel (Safari 3.1)

Reported by: trac@… Owned by: Christian Boos
Priority: normal Milestone: 0.12
Component: version control/browser Version: 0.11-stable
Severity: trivial Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

It seems that Safari needs to have the same Close button workaround applied to it that Firefox does, in blame.js. See the attached patch.

Attachments (1)

trac_close.patch.txt​ (1.0 KB ) - added by trac@… 17 years ago.

Download all attachments as: .zip

Change History (5)

by trac@…, 17 years ago

Attachment: trac_close.patch.txt​ added

comment:1 by Christian Boos, 17 years ago

I also had this impression, but now that I'm using 3.1.1 (on Windows) it works without the workaround.

comment:2 by Christian Boos, 16 years ago

Resolution: → worksforme
Status: new → closed

No longer an issue with Safari 3.1.1 and 3.1.2

comment:3 by Christian Boos, 16 years ago

Milestone: → 0.12
Resolution: worksforme
Severity: normal → trivial
Status: closed → reopened

Well, that change doesn't hurt much and makes the Close button work in Chrome as well.

comment:4 by Christian Boos, 16 years ago

Resolution: → fixed
Status: reopened → closed

Patch applied in [7675], thanks!

While I was at it last week-end, I also refactored the blame code quite a bit and it should be faster now (see [7676]).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.