Edgewall Software
Modify ↓

Opened 16 years ago

Closed 15 years ago

#7239 closed defect (fixed)

umask parameter is lost while instantiating _fcgi.WSGIServer

Reported by: screwdriver@… Owned by: Remy Blank
Priority: normal Milestone: 0.11.3
Component: web frontend Version: 0.12dev
Severity: normal Keywords: fastcgi unix socket
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

umask parameter is not passed from trac.web._fcgi.WSGIServer class constructor to superclass' constructor, thus preventing user from setting sane umask value, which is important when listening on unix domain sockets.

Patch against today's trunk (r7063) attached.

Attachments (1)

trac-7239.diff​ (560 bytes ) - added by screwdriver@… 16 years ago.
fix for the bug

Download all attachments as: .zip

Change History (4)

by screwdriver@…, 16 years ago

Attachment: trac-7239.diff​ added

fix for the bug

comment:1 by Remy Blank, 15 years ago

Milestone: → 0.11.3
Owner: set to Remy Blank

Indeed, this seems to be the case. No comment in the source about this being intentional, either.

I have never used FCGI and I don't have a server to test. Anybody volunteering to test the patch?

comment:2 by screwdriver@…, 15 years ago

My trac box (three instances) runs with this patch fine since I've posted it.

comment:3 by Remy Blank, 15 years ago

Resolution: → fixed
Status: new → closed

Patch applied in [7758]. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Remy Blank to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.