Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 3 years ago

#720 closed defect (fixed)

Timeline should show filename for changeset commit

Reported by: utopiste Owned by: utopiste
Priority: normal Milestone: 0.8
Component: timeline Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:

Description

currently the changeset doesn't list the filename modified/added/deleted by a commit.

currently this option is disable by default

for active this feature

[timeline]

changeset_show_files=True

changeset_files_count=3

patch will follow in trunk

Attachments (0)

Change History (5)

comment:1 by utopiste, 15 years ago

Resolution: fixed
Status: newclosed

Closed in #881

comment:2 by Christopher Lenz, 15 years ago

This is actually the same request as #343 AFAICT. I'll close that one as duplicate then.

comment:3 by Christopher Lenz, 15 years ago

BTW, the link was supposed to be [881] and not #881 I guess.

comment:4 by tbrkic, 15 years ago

Resolution: fixed
Status: closedreopened

I tried to install r996 and got error when viewing the timeline

Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/ModPythonHandler.py", line 194, in handler
    core.dispatch_request(mpr.path_info, args, mpr, env)
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 436, in dispatch_request
    module.run()
  File "/usr/lib/python2.3/site-packages/trac/Module.py", line 44, in run
    self.render()
  File "/usr/lib/python2.3/site-packages/trac/Timeline.py", line 232, in render
    changeset, wiki, milestone)
  File "/usr/lib/python2.3/site-packages/trac/Timeline.py", line 132, in get_info
    max_node = int(self.env.get_config('timeline', 'changeset_show_files',0))
ValueError: invalid literal for int(): False

This seems to be because of the line in Timeline:

max_node = int(self.env.get_config('timeline', 'changeset_show_files',0))

It seems that when you write false/true in trac.ini you get a string back and not boolean.

In Notify.py this code is used:

        enabled = self.env.get_config('notification', 'smtp_enabled', '0')
        if not enabled.lower() in TRUE:

So I suggesst the max_node to change to:

    max_node = self.env.get_config('timeline', 'changeset_show_files',0)        
    if not max_node.lower() in TRUE:

comment:5 by vittorio, 15 years ago

Resolution: fixed
Status: reopenedclosed

the trac.ini format has changed. see TracIni and #841

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain utopiste.
The resolution will be deleted. Next status will be 'reopened'.
to as closed The owner will be changed from utopiste to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.