Timeline should show filename for changeset commit

[utopiste]

currently the changeset doesn't list the filename modified/added/deleted by a commit.

currently this option is disable by default

for active this feature

[timeline]

changeset_show_files=True

changeset_files_count=3

patch will follow in trunk

[utopiste]

Closed in #881

[Christopher Lenz]

This is actually the same request as #343 AFAICT. I'll close that one as duplicate then.

[Christopher Lenz]

BTW, the link was supposed to be [881] and not #881 I guess.

[tbrkic]

I tried to install r996 and got error when viewing the timeline

Traceback (most recent call last):
  File "/usr/lib/python2.3/site-packages/trac/ModPythonHandler.py", line 194, in handler
    core.dispatch_request(mpr.path_info, args, mpr, env)
  File "/usr/lib/python2.3/site-packages/trac/core.py", line 436, in dispatch_request
    module.run()
  File "/usr/lib/python2.3/site-packages/trac/Module.py", line 44, in run
    self.render()
  File "/usr/lib/python2.3/site-packages/trac/Timeline.py", line 232, in render
    changeset, wiki, milestone)
  File "/usr/lib/python2.3/site-packages/trac/Timeline.py", line 132, in get_info
    max_node = int(self.env.get_config('timeline', 'changeset_show_files',0))
ValueError: invalid literal for int(): False

This seems to be because of the line in Timeline:

max_node = int(self.env.get_config('timeline', 'changeset_show_files',0))

It seems that when you write false/true in trac.ini you get a string back and not boolean.

In Notify.py this code is used:

        enabled = self.env.get_config('notification', 'smtp_enabled', '0')
        if not enabled.lower() in TRUE:

So I suggesst the max_node to change to:

    max_node = self.env.get_config('timeline', 'changeset_show_files',0)        
    if not max_node.lower() in TRUE:

[vittorio]

the trac.ini format has changed. see TracIni and #841