Modify ↓
Opened 18 years ago
Closed 17 years ago
#7164 closed defect (fixed)
[PATCH] No alternate links should appear if no page or report exists
| Reported by: | Owned by: | Christian Boos | |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.1 |
| Component: | wiki system | Version: | devel |
| Severity: | minor | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
The altlinks for the content converters should not be added when a wiki page does not exist or when the user is looking at the available reports list. The attached patch checks for page.exists and id != -1 respectively.
Attachments (1)
Change History (5)
by , 18 years ago
| Attachment: | altlinks-removed.diff added |
|---|
comment:1 by , 18 years ago
comment:2 by , 18 years ago
I'm neutral on the reports list. The fact the report list is implemented as a report isn't relevant to the user. The report list page seems more like navigation than a report. Being able to get a CSV export of report titles seemed more like an unintended side-effect than a feature.
comment:3 by , 17 years ago
| Component: | general → wiki system |
|---|---|
| Milestone: | → 0.11.1 |
| Owner: | changed from to |
| Severity: | normal → minor |
comment:4 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Ok, fine, I've committed the full patch in r7396. Thanks!
Note:
See TracTickets
for help on using tickets.
Ok for the empty wiki page, but why for the report list? It's just the report of the reports, i.e. a report in itself and you might want to get it in other formats.