Edgewall Software
Modify

Opened 14 years ago

Closed 13 years ago

#7164 closed defect (fixed)

[PATCH] No alternate links should appear if no page or report exists

Reported by: Dave Gynn <dgynn@…> Owned by: Christian Boos
Priority: normal Milestone: 0.11.1
Component: wiki system Version: devel
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

The altlinks for the content converters should not be added when a wiki page does not exist or when the user is looking at the available reports list. The attached patch checks for page.exists and id != -1 respectively.

Attachments (1)

altlinks-removed.diff (2.0 KB ) - added by Dave Gynn <dgynn@…> 14 years ago.

Download all attachments as: .zip

Change History (5)

by Dave Gynn <dgynn@…>, 14 years ago

Attachment: altlinks-removed.diff added

comment:1 by Christian Boos, 14 years ago

Ok for the empty wiki page, but why for the report list? It's just the report of the reports, i.e. a report in itself and you might want to get it in other formats.

comment:2 by Dave Gynn <dgynn@…>, 14 years ago

I'm neutral on the reports list. The fact the report list is implemented as a report isn't relevant to the user. The report list page seems more like navigation than a report. Being able to get a CSV export of report titles seemed more like an unintended side-effect than a feature.

comment:3 by Christian Boos, 13 years ago

Component: generalwiki system
Milestone: 0.11.1
Owner: changed from Jonas Borgström to Christian Boos
Severity: normalminor

comment:4 by Christian Boos, 13 years ago

Resolution: fixed
Status: newclosed

Ok, fine, I've committed the full patch in r7396. Thanks!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.