Unintuitive History Radios Using

[Markus.Staab]

Hi,

look at a file history, e.g: ​http://trac.edgewall.org/wiki/TracDev/CodingStyle?action=history

first: the radios at the left haven't either a label nor a title, so thats a little usability problem.

second: I think the behaviour of the radios is not intuitiv. if selecting with both radios the same file, you get a diff between the selected and the rev before.. but that is not what you selected..

so i would suggest du add an few lines javascript which prevent the user from selecting two times the same version..

  jQuery(function($) {
    $("input[type=radio][name=version]").change(function() {
      $("input[type=radio][name=old_version]:disabled").attr("disabled", "");
      $("input[type=radio][name=old_version][value="+ $(this).val() +"]").attr("disabled", "disabled");
    });
    $("input[type=radio][name=old_version]").change(function() {
      $("input[type=radio][name=version]:disabled").attr("disabled", "");
      $("input[type=radio][name=version][value="+ $(this).val() +"]").attr("disabled", "disabled");
    });  
  });

[Markus.Staab]

should be no problem to bring the code in a more compact form, but first would be nice to know if somebody is interessted in the change..

[ebray <hyugaricdeau@…>]

This is normal design for viewing changes in a wiki or diffing two files. The left radio button is the file to use on the left side of the diff, and the right radio button selects the file on the right of the diff.

As for selecting the same file in both columns, though the behavior may not be obvious at first, it's perfectly useful and I see no reason to disable it.

[Markus.Staab]

I don't think so…

It is not intuitiv if selecting on both columns the same file and get a diff from the selected version and the previous…

PS: I know about the missing init-state handling of the code above,.. I would provide further code if accepted by the core team.

[ebray <hyugaricdeau@…>]

Maybe unobvious, but I wouldn't call it unintuitive.

[ebray <hyugaricdeau@…>]

Replying to ebray <hyugaricdeau@gmail.com>:

Maybe unobvious, but I wouldn't call it unintuitive.

Not to mention, even if such an action were prevented by JavaScript, there still has to be some behavior to fall back on in environments where JavaScript is disabled.

[Remy Blank]

I agree with comment:2, preventing the user from selecting the same revision for both columns doesn't buy you anything. Better do something sensible in that case.