Edgewall Software
Modify

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#7111 closed defect (fixed)

'checkbox' filter options are created as radio buttons a vise-versa

Reported by: carnold@… Owned by: Remy Blank
Priority: normal Milestone: 0.12
Component: web frontend Version: devel
Severity: minor Keywords: query jquery javascript
Cc: Branch:
Release Notes:
API Changes:

Description (last modified by Tim Hatch)

I was robbing some code and I stumbled upon some brokenness:

source:/trunk/trac/htdocs/js/query.js#L196

property.type == "checkbox" should be property.type == "radio"

Attachments (0)

Change History (12)

comment:1 by Tim Hatch, 11 years ago

Description: modified (diff)
Milestone: 0.11.10.11

Thanks for the catch. It looks like the create* calls in there are also somewhat reversed.

The template code to compare against is source:trunk/trac/ticket/templates/query.html#L80

comment:2 by Christian Boos, 11 years ago

Well, the whole query.js is dating and should be rewritten using jQuery.

comment:3 by Jeroen Ruigrok van der Werven, 11 years ago

But that's also something that can be done for 0.11.1, yes?

It's not like it's a blocker issue or a must-need for 0.11.0's release.

comment:4 by Jeroen Ruigrok van der Werven, 11 years ago

Milestone: 0.110.11.1

The first issue has been fixed in the repository — postpone ticket to 0.11.1 for the jQuery rewrite, I think it would be too invasive at this point in the 0.11 release.

comment:5 by Jeroen Ruigrok van der Werven, 11 years ago

Milestone: 0.11.10.12

After talking with Jonas it would be better to put it for 0.12.

in reply to:  4 comment:6 by Christian Boos, 11 years ago

Replying to jruigrok:

The first issue has been fixed in the repository

To what change do you refer?

comment:7 by Christian Boos, 11 years ago

Keywords: query jquery javascript added
Milestone: 0.130.12
Owner: set to Christian Boos

comment:8 by Christian Boos, 10 years ago

Note: for the refactoring of source:trunk/trac/htdocs/js/query.js@8534 to use jQuery, also take care of using the labels for the filters (see #3919).

comment:9 by Remy Blank, 10 years ago

Owner: changed from Christian Boos to Remy Blank

I'll rewrite query.js using jQuery.

comment:10 by Remy Blank, 10 years ago

Oh wow, that was painful. Very interesting, mind you , but painful!

Anyway, query.js has been rewritten using jQuery in [8603]. The only part I have left mostly unchanged is where the insertion point is determined. All solutions using jQuery that I have found were either longer and less clear, or grossly inefficient.

I have tested the new code with the following browsers, and all work well to the best of my knowledge:

  • Firefox 3.0.14 (Linux)
  • Opera 10.00 build 4585 (Linux)
  • IE 7.0.5730.13 (Windows XP)
  • Google Chrome 2.0.172.43 (Windows XP)
  • Safari 4.0.3 (OS X 10.5.8)

Konqueror 3.5.10 fails, but that's a jQuery issue, so there's not much we can do about it.

I have certainly missed something, so some more testing using various browsers would be most welcome. In the meantime, I'll fix the translation of the field labels.

comment:11 by Remy Blank, 10 years ago

Resolution: fixed
Status: newclosed

The translation of ticket field labels has been fixed in [8604].

in reply to:  10 comment:12 by anonymous, 10 years ago

Replying to rblank:

Oh wow, that was painful. Very interesting, mind you , but painful!

Probably why this ticket was 17 months old :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Remy Blank.
The resolution will be deleted.
to The owner will be changed from Remy Blank to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.