Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#7101 closed enhancement (worksforme)

Adding no-cache meta flag to generated HTML

Reported by: Daher Owned by: Christian Boos
Priority: normal Milestone:
Component: wiki system Version: 0.11b1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I suggest forcing the web browser not to cach pages. The pages right now require everybody to press F5 to see new comments and changes, as well as viewing pages in logged on / off differences and vise versa.. i know it can be forced through the web server, but a suggestion is to include it in the HTML generated page.

Here's the required code in the <head> section:

"<meta http-equiv="no-cache">"

Attachments (0)

Change History (4)

comment:1 by Christian Boos, 17 years ago

Component: renderingwiki system
Milestone: 0.110.11.1
Priority: lownormal

Right, the wiki module doesn't currently make use of the cache control. There should be a req.check_modified call, taking into account the version and the authname.

For the wiki comments, maybe the plugin should do another req.check_modified but then I'm not sure how they'll interact.

comment:2 by Christopher Lenz, 17 years ago

Hmm, but if the Wiki doesn't do the Etag trickery via check_modified, there should be no caching going on. All responses from Trac say "Cache-Control: must-revalidate". That means that browsers are required to check back for changes on every request. Some request handlers use check_modified as to send back a 304 Not Modified. Others just always send back the full response.

Unless something has changed in this area, I'm inclined to close this as worksforme and suggest that a broken proxy or browser is at fault here.

comment:3 by Christian Boos, 17 years ago

Milestone: 0.11.1
Resolution: worksforme
Status: newclosed

Yes, I don't think there's caching going on in the normal case, as checking for differences in the case of "viewing pages in logged on / off differences" was the way to check for permission control.

Adding ETag checks for Wiki page might be not that relevant anyway, as there are many other things that can change besides version and authname (any dynamic content).

So I agree with worksforme.

comment:4 by anonymous, 17 years ago

Summary: Adding no-cach meta flag to generated HTMLAdding no-cache meta flag to generated HTML

Also does not work for me with no proxy and FF 2.0.0.13.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.