Edgewall Software
Modify

Opened 14 years ago

Last modified 7 years ago

#7071 new enhancement

keyboard nav implementation

Reported by: Markus.Staab Owned by:
Priority: lowest Milestone: next-major-releases
Component: version control/browser Version: 0.11b2
Severity: trivial Keywords: ie7
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

why do you do such operations like

+   $(function() { 
+     $('a,input,select,textarea,button') 
+       .focus(function(event) { 
+         ENABLE_KEY_NAV = false; 
+       }) 
+       .blur(function(event) { 
+         ENABLE_KEY_NAV = true; 
+       }); 
+   });

see r6724

if you could do things easier using a :not selector with jquery

$("*:not(a,input,select,textarea,button,option)")

Another little thing: the option tags should also be ingored to be IE friendly

Attachments (0)

Change History (10)

comment:1 by Emmanuel Blot, 14 years ago

Please set the version field when you file in a ticket (and do not clear up the version field when you reopen an existing ticket, btw)

comment:2 by Markus.Staab, 14 years ago

Version: 0.11b2

ok thanks for the info.

comment:3 by Christian Boos, 14 years ago

Component: generalversion control/browser
Owner: changed from Jonas Borgström to Christian Boos
Severity: normaltrivial

I've not tested it, but I suspect that using $('*:not(...)') would result in a huge list of objects, especially on directories with lots of entries (and those page are already expensive). Better to target directly the few elements you need, rather than complementary set.

comment:4 by Markus.Staab, 14 years ago

Argh - You are right..

But this should do the trick:

  $(document).keypress(function(event) {
    if(!$(event.target).is("a,input,button,textarea,select,option"))
    {
    }
  }

comment:5 by Markus.Staab, 14 years ago

Independet of my implementation: the option tag is missing in the blacklist.. IE Triggers an option element where FF triggers an SELECT Element for DropDown-Selects..

in reply to:  description comment:6 by Remy Blank, 14 years ago

Keywords: needinfo added

Replying to Markus.Staab:

Another little thing: the option tags should also be ingored to be IE friendly

Could you provide a way to check this behavior? This would help me to test the fix.

comment:7 by Christian Boos, 13 years ago

Milestone: 0.12

I'll look again into this one.

comment:8 by Christian Boos, 13 years ago

Keywords: ie7 added; needinfo removed
Milestone: 0.120.12.1
Priority: normallow

in reply to:  7 comment:9 by Christian Boos, 12 years ago

Milestone: next-minor-0.12.xnext-major-0.1X
Priority: lowlowest

Replying to cboos:

I'll look again into this one.

… later.

comment:10 by Ryan J Ollos, 7 years ago

Owner: Christian Boos removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.