keyboard nav implementation

[Markus.Staab]

why do you do such operations like

+   $(function() { 
+     $('a,input,select,textarea,button') 
+       .focus(function(event) { 
+         ENABLE_KEY_NAV = false; 
+       }) 
+       .blur(function(event) { 
+         ENABLE_KEY_NAV = true; 
+       }); 
+   });

see r6724

if you could do things easier using a :not selector with jquery

$("*:not(a,input,select,textarea,button,option)")

Another little thing: the option tags should also be ingored to be IE friendly

[Emmanuel Blot]

Please set the version field when you file in a ticket (and do not clear up the version field when you reopen an existing ticket, btw)

[Markus.Staab]

ok thanks for the info.

[Christian Boos]

I've not tested it, but I suspect that using $('*:not(...)') would result in a huge list of objects, especially on directories with lots of entries (and those page are already expensive). Better to target directly the few elements you need, rather than complementary set.

[Markus.Staab]

Argh - You are right..

But this should do the trick:

  $(document).keypress(function(event) {
    if(!$(event.target).is("a,input,button,textarea,select,option"))
    {
    }
  }

[Markus.Staab]

Independet of my implementation: the option tag is missing in the blacklist.. IE Triggers an option element where FF triggers an SELECT Element for DropDown-Selects..

[Remy Blank]

Replying to Markus.Staab:

Another little thing: the option tags should also be ingored to be IE friendly

Could you provide a way to check this behavior? This would help me to test the fix.

[Christian Boos]

I'll look again into this one.

[Christian Boos]

Replying to cboos:

I'll look again into this one.

… later.