No such changeset error after a login attempt

[dkt]

I'm using a multirepo branch of Trac and Mercurial plugin 0.12.

I get the following error when I try to login:

No changeset None in the repository

I read the file log but I have no clue what's wrong.

2008-03-13 17:50:34,392 Trac[loader] DEBUG: Loading hg from /var/trac/qutecom/plugins/TracMercurial-0.12.0.1-py2.5.egg
2008-03-13 17:50:34,395 Trac[default_workflow] DEBUG: Workflow actions at initialization: {'resolve': {'operations': [u'set_resolution'], 'name': 'resolve', 'default': 
0, 'newstate': u'closed', 'oldstates': [u'new', u'assigned', u'accepted', u'reopened'], 'permissions': [u'TICKET_MODIFY']}, 'accept': {'operations': [u'set_owner_to_sel
f'], 'name': 'accept', 'default': 0, 'newstate': u'accepted', 'oldstates': [u'new', u'assigned', u'accepted', u'reopened'], 'permissions': [u'TICKET_MODIFY']}, 'leave':
 {'operations': [u'leave_status'], 'name': 'leave', 'default': 1, 'newstate': u'*', 'oldstates': [u'*'], 'permissions': []}, 'reopen': {'operations': [u'del_resolution'
], 'name': 'reopen', 'default': 0, 'newstate': u'reopened', 'oldstates': [u'closed'], 'permissions': [u'TICKET_CREATE']}, 'reassign': {'operations': [u'set_owner'], 'na
me': 'reassign', 'default': 0, 'newstate': u'assigned', 'oldstates': [u'new', u'assigned', u'accepted', u'reopened'], 'permissions': [u'TICKET_MODIFY']}, '_reset': {'op
erations': ['reset_workflow'], 'name': 'reset', 'default': 0, 'newstate': 'new', 'oldstates': [], 'permissions': []}}

2008-03-13 17:50:34,397 Trac[env] WARNING: base_url option not set in configuration, generated links may be incorrect
2008-03-13 17:50:34,397 Trac[main] DEBUG: Dispatching <Request "GET u'/login'">
2008-03-13 17:50:34,405 Trac[svn_fs] DEBUG: Subversion bindings imported
2008-03-13 17:50:34,421 Trac[main] WARNING: 404 No such changeset (No changeset None in the repository)

[Christian Boos]

I have that as well, must be a str(rev) with rev==None somewhere.

[dkt]

Patch of the log module

[dkt]

Patch of mercurial plugin (previous comment attached file is wrong)

[dkt]

Patch of the log module

[dkt]

I've put in attachment some patches which correct bug. As expected, bug came from a rev!=None with rev in string format. I had another bug with multirepo branch during request matching. When a login request is done (/login), the logModule matches and authentication is messed up. The attached patch redefines the matching pattern.

[anonymous]

tested and works even with TracAccountManager 0.2dev-r3111

[anonymous]

Thanks, this worked for me too. Without these patches, I could not log in at all, making Trac not very useful.

[Christian Boos]

reworked log.patch​ committed as [6850].

For the original problem (was it even related?), I'd prefer to fix the fact that rev ends up being the string 'None' rather than coping with it in the Mercurial plugin. But for now, I can't figure out how to reproduce the issue…

[remy.blank@…]

How about MercurialRepository.normalize_rev()? A simple search for str(rev) turned that up, so good guess!

I have the same problem with two repositories, an SVN repo as the default and an additional Mercurial repo. The error comes when I select the root of the Hg repo, then click on "Revision log". The url is:

​http://localhost:8000/multi/log/hg/

However, if I change the url to the following, the problem disappears:

​http://localhost:8000/multi/log/hg/?rev=

Probably because rev becomes the empty string instead of None.

The following patch fixes the problem for me:

tracext/hg/backend.py

@@ -292 +292 @@
 
     def normalize_rev(self, rev):
         """Return the changelog node for the specified rev"""
-        return self.hg_display(self.hg_node(str(rev)))
+        if rev is not None:
+            rev = str(rev)
+        return self.hg_display(self.hg_node(rev))
 
     def short_rev(self, rev):
         """Return the revision number for the specified rev, in compact form.

[Christian Boos]

Right, that was it.

Fixed in [6854:6858] (hm, sorry for the mess).