trac-admin initenv fails when passed single quote on command line

[justin.r.cutler@…]

When trac-admin is called with the non-interactive mode of initenv, an exception is raised if the environment name includes a single quote.

Example:

$ trac-admin trac/test initenv "Test's Project" sqlite:db/trac.db \
  svn svn/test/ /usr/share/trac/templates/

Returns:

Command failed: No closing quotation

[justin.r.cutler@…]

Replying to anonymous:

Where precisely is this fixed? I have tested this against the latest code in 0.10.5dev, and this bug still exists (as of r6692).

[Christian Boos]

comment:1 and comment:2 were Ticket spam.

The bug exists, I've taken a look. Fixing it requires us to not enclose each argument within a pair of single quotes (change introduced in [133]), and I have yet to check for the implications of that change.

[Thijs Triemstra]

When testing this with 0.13 trunk I see:

$ trac-admin test2 initenv "Thijs's project" sqlite:db/trac.db svn
ValueError: No closing quotation

With the interactive wizard it works fine:

$ trac-admin test initenv
Creating a new Trac environment at /tmp/test

Trac will first ask a few questions about your environment 
in order to initialize and prepare the project database.

 Please enter the name of your project.
 This name will be used in page titles and descriptions.

Project Name [My Project]> Thijs's project
 
 Please specify the connection string for the database to use.
 By default, a local SQLite database is created in the environment
 directory. It is also possible to use an already existing
 PostgreSQL database (check the Trac documentation for the exact
 connection string syntax).

Database connection string [sqlite:db/trac.db]> 

Creating and Initializing Project
 Installing default wiki pages
  
...

The latest documentation can also always be found on the project
website:

  http://trac.edgewall.org/

Congratulations!

[Thijs Triemstra]

Replying to thijstriemstra:

When testing this with 0.13 trunk I see:

$ trac-admin test2 initenv "Thijs's project" sqlite:db/trac.db svn
ValueError: No closing quotation

But where is this ValueError being thrown..

[psuter <petsuter@…>]

Replying to thijstriemstra:

But where is this ValueError being thrown..

Probably in shlex.split() (called by trac.admin.console.TracAdmin arg_tokenize()). I get the same in a Python shell:

>>> import shlex
>>> shlex.split('"')

Traceback (most recent call last):
...
ValueError: No closing quotation

Although shlex.split('initenv "Test\'s project" sqlite') seems to work here.

[Ryan J Ollos]

#12246 closed as a duplicate.

[Jun Omae]

Proposed fix is log:jomae.git@t6998, untested with Windows.

[Jun Omae]

That works fine on Windows 7 with Python 2.7 amd64.

C>..\venv\py27-amd64\Scripts\python.exe trac\admin\console.py C:\usr\var\trac\1.0 session add "blah'blah:1" "Blah's ''name''"

C>..\venv\py27-amd64\Scripts\python.exe trac\admin\console.py C:\usr\var\trac\1.0 session list

SID        Auth  Last Visit  Name             Email
---------------------------------------------------
blah'blah  1     2015-12-01  Blah's ''name''
jun66j5    1     2015-06-04

C>..\venv\py27-amd64\Scripts\python.exe trac\admin\console.py C:\usr\var\trac\1.0 session delete "blah'blah:1"

C>..\venv\py27-amd64\Scripts\python.exe trac\admin\console.py C:\usr\var\trac\1.0 session list

SID      Auth  Last Visit  Name  Email
--------------------------------------
jun66j5  1     2015-06-04

[Ryan J Ollos]

Works well on OSX 10.11.1 with Python 2.7.10. It will be great to fix such a long-standing bug.

[Jun Omae]

Added unit tests in log:jomae.git@t6998. I'll push the changes tonight.

[Jun Omae]

Committed in [14646] and merged to trunk in [14647].

[Jun Omae]

Follow-up to [14646], fixed missing return statement in [14685] and merged to trunk in [14686].