Edgewall Software
Modify

Opened 17 years ago

Closed 16 years ago

#6955 closed enhancement (duplicate)

ignores in changeset views

Reported by: coudercd Owned by: Christian Boos
Priority: normal Milestone:
Component: version control/changeset view Version: 0.11b1
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Setting ignore for blank lines and white space changes does not work for me on C files. When i do a svn diff -c rev -x '-w' from the command line for the same changeset i have the expected behavior.

Attachments (0)

Change History (9)

comment:1 by Christian Boos, 17 years ago

Keywords: needinfo added
Milestone: 0.11

Please provide a detailed test case (i.e. the old and new content of that C file).

comment:2 by Tim Hatch, 17 years ago

I have a feeling this is a duplicate of #4329

comment:3 by anonymous, 17 years ago

Yes I agree, mainly on the following : "However, if a block contains both whitespace and other changes the entire section is shown in the diff listing and that section may include a number of lines which only have whitespace changes."

As we are maintaining code done by other people we often do some reformatting to meet our needs of coding standards. So we run some diffing with white space and blank line changes ignored to be sure that only indentation and spacing had been done.

IMHO, it is a bit "weird" to not ignore changes when they have been asked for. Could it be possible to choose which kind of ignore we want (partial or full) ?

comment:4 by nhorgil2002@…, 17 years ago

Component: version control/changeset viewgeneral
Owner: changed from Christian Boos to Jonas Borgström
Priority: normalhigh

Another error message appeared on my trac, please help..

Python Traceback

Traceback (most recent call last):

File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 406, in dispatch_request

dispatcher.dispatch(req)

File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 191, in dispatch

chosen_handler = self._pre_process_request(req, chosen_handler)

File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 263, in _pre_process_request

chosen_handler = f.pre_process_request(req, chosen_handler)

File "/usr/lib/python2.4/site-packages/trac/versioncontrol/api.py", line 73, in pre_process_request

self.get_repository(req.authname).sync()

File "/usr/lib/python2.4/site-packages/trac/versioncontrol/api.py", line 104, in get_repository

repos = self._connector.get_repository(rtype, rdir, authname)

File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 234, in get_repository

repos = SubversionRepository(dir, None, self.log)

File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 264, in init

raise TracError("%s does not appear to be a Subversion repository." \

TracError: /srv/svn does not appear to be a Subversion repository.

Thanks!

comment:5 by Tim Hatch, 17 years ago

Component: generalversion control/changeset view
Owner: changed from Jonas Borgström to Christian Boos
Priority: highnormal

That belongs in another ticket, but is probably an install error. MailingList or IrcChannel, your choice.

comment:6 by anonymous, 17 years ago

Keywords: infogiven added; needinfo removed

comment:7 by anonymous, 17 years ago

Milestone: 0.11.1
Type: defectenhancement

As it does not seem to be a bug i change the ticket into enhancement type and get it out of 0.11 to avoid blocking release.

comment:8 by coudercd, 17 years ago

Oops, i forgot to provide author for the previous change.

comment:9 by Christian Boos, 16 years ago

Keywords: infogiven removed
Milestone: 0.11.2
Resolution: duplicate
Status: newclosed

In the absence of more specific informations, let's close this as duplicate of #4329.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.