Edgewall Software
Modify

Opened 14 years ago

Last modified 6 years ago

#6947 new enhancement

Change in colouring scheme for nested replies in the ticket

Reported by: Przemyslaw Lapko <przemyslaw.lapko@…> Owned by:
Priority: lowest Milestone: next-major-releases
Component: wiki system Version:
Severity: minor Keywords: citation
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Currently, when another reply to the ticket's description or comment is added, colours of the reply levels are "shifted" - thus, for example, the original post is marked with different colours in each reply. I think that colours for particular level should be preserver, and just another colour should be introduced "on the left" (currently new colour appears "on the right").

That would make finding the same sentences in different replies much easier (user will just search for the same colour).

Attachments (0)

Change History (7)

comment:1 by Christian Boos, 14 years ago

Component: ticket systemwiki system
Keywords: citation added
Milestone: 2.0
Severity: normalminor

Interesting idea, but I don't exactly see how this could be done in practice.

Perhaps once we have the whole WikiDom in memory and are able to known the deepest citation level and somehow preallocate the colors to each level

Consider:

> a
>> b

text
> a
>>> c

Here, 'c' should get 'citation1' (say, red), 'b' should get 'citation2' and 'a' should get 'citation3'. But there's no way you can know that before having seen >>> c.

comment:2 by anonymous, 14 years ago

Yes, it's not so simple. Maybe you could consider "reverting" the colors after displaying every post - so in one post the "green-blue-red" sequence will become "red-blue-green", and in another "green-blue-red-black" (the coloring sequence should be preserved for all posts - just as it works now) will become "black-red-blue-green", and so on.

All you need to know is the deepest citation level in particular post (you can use some incremented variable while processing the post) and some mechanizm to "revert" the order of colors after - maybe playing with the styles?

in reply to:  1 comment:3 by Tim Hatch, 14 years ago

Replying to cboos:

Interesting idea, but I don't exactly see how this could be done in practice.

How about using css to apply the colors? It works just like that, actually.

comment:4 by Przemyslaw Lapko <przemyslaw.lapko@…>, 14 years ago

Just to explain the reverting idea in some details.

Let's assume, that the default color order is always: ||||...
So your example before reverting will look like:
| a
|| b
text
| a
||| c

The deepest citation level is 3, so we revert 3 colors at the beginning of our default sequence:
||| becomes
|||

Now, let's apply the change to the example:
| a
|| b
text
| a
||| c

Nothing spectacular, right? The actual result will be visible after the next reply.

First, the reply with the default coloring order: ||||...
|| a
||| b
| text
reply
|| a
|||| c

This time, the deepest citation level is 4, so we revert 4 colors at the beginning of our default sequence:
|||| becomes
||||

After applying the change the reply looks like this:
|| a
||| b
| text
reply
|| a
|||| c

Colors in the reply have been just "shifted" to the right comparing to the original post.

Of course the tricky part is "reverting" - but I think it could be done manipulating styles (some css and javascript).

comment:5 by Christian Boos, 11 years ago

Milestone: 2.0unscheduled

Milestone 2.0 deleted

comment:6 by Christian Boos, 11 years ago

Milestone: triagingnext-major-0.1X
Priority: normallowest

PatchWelcome (but wait until the WikiEngine refactoring is complete though…)

comment:7 by Ryan J Ollos, 6 years ago

Owner: Christian Boos removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.