diff renderer has problems processing file names

[theultramage@…]

I discovered a glitch in how trac renders unified diffs. Specifically, depending on the old and new filename, the results will vary a lot.

Following are several examples:

---

same name

x.txt

@@ -1 +1 @@
 this is example text
 and one more line
-no more lines
+no more lines

---

different name, no dot in name (in /trunk, this displays as "(a) xxx vs. (b) yyy")

(a) xxx vs. (b) yyy

@@ -1 +1 @@
 this is example text
 and one more line
-no more lines
+no more lines

---

different name, dot in name

.txt

@@ -1 +1 @@
 this is example text
 and one more line
-no more lines
+no more lines

for reference, this is how it looks like on /trunk r6649

as you can see, the 'xxx' and 'yyy' replaced the 'old'/'new' columns, and the title is completely wrong.

[theultramage@…]

screenshot of how a diff of two differently named files with a dot renders like