Opened 18 years ago
Closed 18 years ago
#6909 closed defect (duplicate)
error using name "rebecca" on wiki-formatted regions
| Reported by: | Owned by: | Christian Boos | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | wiki system | Version: | 0.10-stable |
| Severity: | normal | Keywords: | |
| Cc: | Branch: | ||
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
Using the name "rebecca" in wiki-formatted text-areas throws this error for me:
Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 406, in dispatch_request
dispatcher.dispatch(req)
File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 237, in dispatch
resp = chosen_handler.process_request(req)
File "/usr/lib/python2.4/site-packages/trac/wiki/web_ui.py", line 135, in process_request
self._render_view(req, db, page)
File "/usr/lib/python2.4/site-packages/trac/wiki/web_ui.py", line 442, in _render_view
req.hdf['wiki'] = {
File "/usr/lib/python2.4/site-packages/trac/wiki/formatter.py", line 1001, in wiki_to_html
Formatter(env, req, absurls, db).format(wikitext, out, escape_newlines)
File "/usr/lib/python2.4/site-packages/trac/wiki/formatter.py", line 824, in format
result = re.sub(self.wiki.rules, self.replace, line)
File "sre.py", line 142, in sub
return _compile(pattern, 0).sub(repl, string, count)
File "/usr/lib/python2.4/site-packages/trac/wiki/formatter.py", line 770, in replace
replacement = self.handle_match(fullmatch)
File "/usr/lib/python2.4/site-packages/trac/wiki/formatter.py", line 763, in handle_match
return external_handler(self, match, fullmatch)
File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 697, in <lambda>
y, z))
File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/changeset.py", line 715, in _format_changeset_link
changeset = self.env.get_repository().get_changeset(rev)
File "build/bdist.linux-i686/egg/tracdarcs/repository.py", line 114, in get_changeset
File "build/bdist.linux-i686/egg/tracdarcs/repository.py", line 179, in normalize_rev
ValueError: invalid literal for int(): ebecca
This is because the parser is identifying changesets by looking for an "r" followed by numbers or 6+ digits of hex, which happens to be in Rebecca's name. My repository doesn't have a changeset matching "ebecca", so an error is thrown. I have no idea how this trac is mapping rebecca to r6621
I fixed this by adding an error handler for this case, see attached patch. I'm working from a freshly updated svn: http://svn.edgewall.com/repos/trac/branches/0.10-stable
The patch was created using: trac/versioncontrol/web_ui/svn diff > rebecca.patch
Attachments (1)
Change History (2)
by , 18 years ago
| Attachment: | rebecca.patch added |
|---|
comment:1 by , 18 years ago
| Milestone: | 0.10.5 |
|---|---|
| Resolution: | → duplicate |
| Status: | new → closed |
This issue has been fixed one year ago on the trunk, see #4261



patch to fix wiki parsing of "rebecca"