Edgewall Software
Modify

Opened 17 years ago

Closed 17 years ago

#6821 closed defect (fixed)

Better patch to fix #5783

Reported by: amax@… Owned by: Christian Boos
Priority: normal Milestone: 0.10.5
Component: general Version: 0.10.4
Severity: normal Keywords: mysql
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

Hi,

Earlier we contributed a patch to solve #5783, which was accepted and merged into trunk. With more experience, we have found the attached patch to be better. The first patch solved the original bug most of the time, but it did sporadically show up again. This new patch is more thorough; we've used it for about four months, and so far (knock on wood) the error has not reoccurred.

This try-catch approach was considered at one point (if you dig into the mailing lists), but at the time it appeared not to be necessary. I think now that it is.

-Aaron

Attachments (2)

trac_better_mysql_fix.diff (566 bytes ) - added by amax@… 17 years ago.
patch: purportedly better fix for #5783
trac_better_mysql_fix.2.diff (833 bytes ) - added by amax@… 17 years ago.
patch: purportedly better fix for #5783 (previous upload of this name was incorrect, this one is the right patch)

Download all attachments as: .zip

Change History (5)

by amax@…, 17 years ago

Attachment: trac_better_mysql_fix.diff added

patch: purportedly better fix for #5783

by amax@…, 17 years ago

patch: purportedly better fix for #5783 (previous upload of this name was incorrect, this one is the right patch)

comment:1 by anonymous, 17 years ago

Just to clarify, the patch labeled trac_better_mysql_fix.diff is not correct. My mistake - I uploaded the wrong patch. The correct patch is trac_better_mysql_fix.2.diff .

comment:2 by Christian Boos, 17 years ago

Keywords: mysql added
Milestone: 0.10.5
Owner: changed from Jonas Borgström to Christian Boos
Status: newassigned

Thanks for the patch!

comment:3 by Christian Boos, 17 years ago

Resolution: fixed
Status: assignedclosed

Applied in r6510 for trunk and r6511 for 0.10.5dev.

I removed the non-global import MySQLdb statements, which IIRC also can lead to trouble. I tested the modified patch on trunk, but not on 0.10.5dev, I hope everything is right there.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.